-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: Release 2 gems #1068
release: Release 2 gems #1068
Conversation
WARNING: An additional commit was added while this release PR was open. Commit link: d8ebe73 Message: |
@@ -7,7 +7,7 @@ | |||
module OpenTelemetry | |||
module Instrumentation | |||
module Trilogy | |||
VERSION = '0.50.0' | |||
VERSION = '0.1.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arielvalentin is this the right version? It hasn't been released, so it should be fine, but I feel like you probably chose 0.50.0 intentionally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yessir. We have releases internally with the same gem name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sooo, what should the version be? I don't think you want to release it as 0.1.0. Can you fix up this PR 🙏 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well goodness gracious! I totally misread the diff and completely missed that this PR rolled us back to 0.1.0
.
Another ⭐ awarded to @fbogsany for avoiding catastrophes!
instrumentation/trilogy/lib/opentelemetry/instrumentation/trilogy/version.rb
Outdated
Show resolved
Hide resolved
…ogy/version.rb Co-authored-by: Ariel Valentin <[email protected]>
All releases completed successfully. Successfully released opentelemetry-instrumentation-trilogy 0.50.0 Successfully released opentelemetry-exporter-otlp 0.21.1 |
This pull request prepares new gem releases for the following gems:
For each gem, this pull request modifies the gem version and provides an initial changelog entry based on conventional commit messages. You can edit these changes before merging, to release a different version or to alter the changelog text.
The generated changelog entries have been copied below:
opentelemetry-instrumentation-trilogy
v0.1.0 / 2021-12-31
opentelemetry-exporter-otlp
v0.21.1 / 2021-12-31
none