Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: Release 2 gems #1068

Merged
merged 4 commits into from
Jan 5, 2022
Merged

release: Release 2 gems #1068

merged 4 commits into from
Jan 5, 2022

Conversation

github-actions[bot]
Copy link
Contributor

This pull request prepares new gem releases for the following gems:

  • opentelemetry-instrumentation-trilogy 0.1.0 (initial release)
  • opentelemetry-exporter-otlp 0.21.1 (was 0.21.0)

For each gem, this pull request modifies the gem version and provides an initial changelog entry based on conventional commit messages. You can edit these changes before merging, to release a different version or to alter the changelog text.

  • To confirm this release, merge this pull request, ensuring the "release: pending" label is set. The release script will trigger automatically on merge.
  • To abort this release, close this pull request without merging.

The generated changelog entries have been copied below:


opentelemetry-instrumentation-trilogy

v0.1.0 / 2021-12-31

  • Initial release.

opentelemetry-exporter-otlp

v0.21.1 / 2021-12-31

  • FIXED: Allow OTLP Exporter compression value of none

@github-actions
Copy link
Contributor Author

github-actions bot commented Jan 4, 2022

WARNING: An additional commit was added while this release PR was open.
You may need to add to the changelog, or close this PR and prepare a new one.

Commit link: d8ebe73

Message:
chore: add max faraday version to tests to prevent koala breaking on faraday 2.0, to be removed once koala itself fixes versioning (#1070)

@@ -7,7 +7,7 @@
module OpenTelemetry
module Instrumentation
module Trilogy
VERSION = '0.50.0'
VERSION = '0.1.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arielvalentin is this the right version? It hasn't been released, so it should be fine, but I feel like you probably chose 0.50.0 intentionally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yessir. We have releases internally with the same gem name.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sooo, what should the version be? I don't think you want to release it as 0.1.0. Can you fix up this PR 🙏 ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well goodness gracious! I totally misread the diff and completely missed that this PR rolled us back to 0.1.0.

Another ⭐ awarded to @fbogsany for avoiding catastrophes!

@fbogsany fbogsany merged commit da0b8f8 into main Jan 5, 2022
@github-actions github-actions bot added release: complete Automated release completed successfully and removed release: pending Automated release is pending labels Jan 5, 2022
@github-actions
Copy link
Contributor Author

github-actions bot commented Jan 5, 2022

All releases completed successfully.

Successfully released opentelemetry-instrumentation-trilogy 0.50.0

Successfully released opentelemetry-exporter-otlp 0.21.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: complete Automated release completed successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants