YouTube + Music #401

Titiftw · 2024-09-25T15:13:24Z

Hi,
I found your project and I really enjoyed it. However, it was lacking few functionalities that I tried to add myself. Note that I am not a Python nor a Svelte expert but if it may help you, it includes Music upload and YouTube (that one might require some fanciness on the link input).
I'm missing software for the translations though.

If you think this can help you, feel free to use it. If not, then please discard that PR!

Kind regards,
Jason

View video Wrong if else Issue iframe Edit on the displayed video Small fixes Hide title, better button location Trying to hide title as showinfo no longer works Display video Reverted Music upload File input not declared Removed compressing on musics Issue uploading music Trying to display size & type Images not there Trying stuffs Trying with different object Reverted Added type, corrected filename Display differnt image if music Extra } Updated user storage used Issue in loop Management for music Set music from Library Test blo Audio player Wrong link Trying this Back to list Listing stuffs which are deleted Issue filtering Wrong path set Issue when adding a music to a quizz not being linked to it Wrong var used Debug Debug Debug Blo Debug Magic Reverted Fix in calculate hash I'm banana Remove storage path Calculate hash is bugged Blo Blo Debug Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Log Log Blo Log Log Trying Save item Blo Blo Always delete button Delete button always showed Blo Banana Added player on admin Fix player UI fixes Removed hardcoded blocorp

for more information, see https://pre-commit.ci

classquiz/db/models.py

classquiz/helpers/__init__.py

mawoka-myblock · 2024-09-25T15:16:15Z

classquiz/routers/editor.py

-        for image in images_to_delete:
-            if image is not None:
-                try:
-                    await storage.delete([image])
-                except DeletionFailedError:
-                    pass


Why remove that?

I don't see "images_to_delete" being populated. Am I wrong? It seems it's always set to []

It should find the images that were in the quiz before it was saved and deletes them, but I'll check that

classquiz/worker/storage.py

frontend/package-lock.json

mawoka-myblock · 2024-09-25T15:25:49Z

frontend/src/routes/edit/files/+page.svelte

-					loading="lazy"
-					alt={image.alt_text || $t('file_dashboard.not_available')}
-				/>
+				{#if file.mime_type === 'music/mp3'}


mime type oversight

What do you mean ?

mawoka-myblock · 2024-09-25T15:26:02Z

frontend/src/routes/edit/files/+page.svelte

-					alt={image.alt_text || $t('file_dashboard.not_available')}
-				/>
+				{#if file.mime_type === 'music/mp3'}
+					<svg


svg source?

https://www.svgrepo.com/svg/2225/music

frontend/src/routes/edit/musics/+page.svelte

mawoka-myblock · 2024-09-25T15:27:39Z

frontend/src/routes/edit/musics/+page.svelte

+				});
+			});
+			xhr.open('POST', `/api/v1/storage/raw/${file.name}`, true);
+			xhr.setRequestHeader('Content-Type', 'music/mp3');


Not always mp3

You're right but I don't have any other option (checking file extension?)

mawoka-myblock · 2024-09-25T15:28:29Z

frontend/src/routes/edit/musics/+page.svelte

+	let file: File;
+	let file_data: undefined | Blob = undefined;
+
+	const compress_music = async () => {


What's this purpose?

None, but I didn't manage and spend time to remove the way it used to work. So I kept the compression function if compression could be added.

mawoka-myblock · 2024-09-25T15:32:41Z

Thank you soo much for this PR! Really appreciate it! I've just looked through the code roughly and put some notes down. Please address them or comment on them and mark them as resolved afterwards. Another thing I haven't seen: Where's the YouTube player? maybe I just missed it. I'll also have to test this code locally. Again, many thanks for such a huge PR!

Titiftw · 2024-09-25T15:39:05Z

Owner

The YouTube player is done using iframe:

Once the link is added to the card, it gets displayed on it:

Might still be missing from the Admin card as I didn't test it fully as I realized that the YouTube video title would be showed to every body... Not the greatest idea for Blind tests.

Titiftw · 2024-09-25T15:46:59Z

@mawoka-myblock I'm having issue "unlinking" images/musics from a quiz. If I remove a music or an image from a quiz and it becomes unused in any quiz, the call "/storage/list" still shows it as part of a quiz which prevents the file delete button to appear. It seems that the storage worker line await new_quiz.storageitems.remove(item) always fails as the item UUID doesn't exist.
Any idea what's wrong?

mawoka-myblock · 2024-09-25T15:47:59Z

I'm gonna have to look into that when I got time. Expect the weekend in 3 days

for more information, see https://pre-commit.ci

# Conflicts: # classquiz/routers/editor.py

mawoka-myblock · 2024-10-05T15:49:48Z

I haven't forgotten you yet!

Titiftw · 2024-10-07T07:02:46Z

No worries @mawoka-myblock, take your time! In the meantime, I also worked on another feature to fix several points which were blocking my tests:

When playing, there was a bug when a player would reconnect more than once which could potentially happen. I fixed it in my feature branch (now the player can refresh any time the game, as long as it is not answering a question).
When playing, the total score showed on the player screen was wrong if the player reconnected.
When playing, a player could give X answers if it would click X times on the "Validate" button. I adjusted the disabled button logic in the frontend and also return an "already_replied" on the WebSocket.
When playing on a CHECK question, the player could select multiple answers. I made sure all the selected answers were removed when clicking on another answer.
I also made few styles fixes (annoying scrollbar when playing for instance).

I'll create another PR if you don't mind!

mawoka-myblock · 2024-10-18T10:19:48Z

Okay, so I got it installed and here are some things I noticed:

The music upload does not work
- Why create a new endpoint for the music upload? Why not resuse the video one?
- After the upload, the popup closes but nothing happens on in the editor
YouTube URL input definitely needs some cosmetic work
YouTube doesn't autoplay on the play page
YouTube video isn't centered
The "Old School" mode doesn't have the YouTube video on the player's screens

I could fix them myself, though some need an explanation on your side ;)

mawoka-myblock · 2024-10-18T10:20:51Z

The "view" page also seems to be missing the Youtube player, just like the "Practice" mode

Titiftw · 2024-10-18T10:40:39Z

Hi @mawoka-myblock, let me answer your questions:

The music upload does not work
- Why create a new endpoint for the music upload? Why not resuse the video one? => Because I wanted to have the filename stored; otherwise it is complicated to find back the song in the library - which I didn't find supported by the video upload endpoint.
- After the upload, the popup closes but nothing happens on in the editor => You're right, I typically then used the Library to add the music onto the slide. I'll have a look.
YouTube URL input definitely needs some cosmetic work => I'll propose something but styling is not my cup of tea.
YouTube doesn't autoplay on the play page => I'll provide a fix.
YouTube video isn't centered => Same.
The "Old School" mode doesn't have the YouTube video on the player's screens => Same.
The "view" page also seems to be missing the Youtube player, just like the "Practice" mode => Same.

JasonDavidI8C and others added 2 commits September 25, 2024 17:08

[pre-commit.ci] auto fixes from pre-commit.com hooks

f917e08

for more information, see https://pre-commit.ci

Titiftw marked this pull request as draft September 25, 2024 15:13

Titiftw added 2 commits September 25, 2024 17:26

Problem with PR

a35939b

Merge remote-tracking branch 'origin/master'

071ae08

mawoka-myblock requested changes Sep 25, 2024

View reviewed changes

PR remarks

c76d9e8

Titiftw and others added 10 commits September 25, 2024 17:54

Display YouTube when presenting, remove line as suggested by PR

f85e95a

Analysis issues

c240b83

[pre-commit.ci] auto fixes from pre-commit.com hooks

ce31cab

for more information, see https://pre-commit.ci

Imports went away

24aa0e7

Merge branch 'master' of https://github.com/Titiftw/ClassQuiz

95732b1

Issue analysis

acf6015

[pre-commit.ci] auto fixes from pre-commit.com hooks

70811df

for more information, see https://pre-commit.ci

Tried to simplify function, removed unused arg

aec1dce

Merge branch 'master' into feature/fixes

c1223c0

# Conflicts: # classquiz/routers/editor.py

Merge branch 'feature/fixes'

990e328

Titiftw marked this pull request as ready for review September 25, 2024 19:45

mawoka-myblock mentioned this pull request Oct 18, 2024

Feature/fixes pr #408

Draft

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YouTube + Music #401

YouTube + Music #401

Titiftw commented Sep 25, 2024

mawoka-myblock Sep 25, 2024

Titiftw Sep 25, 2024

mawoka-myblock Sep 25, 2024

mawoka-myblock Sep 25, 2024

Titiftw Sep 25, 2024

mawoka-myblock Sep 25, 2024

Titiftw Sep 25, 2024

mawoka-myblock Sep 25, 2024

Titiftw Sep 25, 2024

mawoka-myblock Sep 25, 2024

Titiftw Sep 25, 2024

mawoka-myblock commented Sep 25, 2024

Titiftw commented Sep 25, 2024

Titiftw commented Sep 25, 2024

mawoka-myblock commented Sep 25, 2024

mawoka-myblock commented Oct 5, 2024

Titiftw commented Oct 7, 2024 •

edited

Loading

mawoka-myblock commented Oct 18, 2024

mawoka-myblock commented Oct 18, 2024

Titiftw commented Oct 18, 2024

YouTube + Music #401

Are you sure you want to change the base?

YouTube + Music #401

Conversation

Titiftw commented Sep 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mawoka-myblock commented Sep 25, 2024

Titiftw commented Sep 25, 2024

Titiftw commented Sep 25, 2024

mawoka-myblock commented Sep 25, 2024

mawoka-myblock commented Oct 5, 2024

Titiftw commented Oct 7, 2024 • edited Loading

mawoka-myblock commented Oct 18, 2024

mawoka-myblock commented Oct 18, 2024

Titiftw commented Oct 18, 2024

Titiftw commented Oct 7, 2024 •

edited

Loading