-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
YouTube + Music #401
Open
Titiftw
wants to merge
15
commits into
mawoka-myblock:master
Choose a base branch
from
Titiftw:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
YouTube + Music #401
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
36b1561
Trying to add a Youtube URL
JasonDavidI8C f917e08
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a35939b
Problem with PR
Titiftw 071ae08
Merge remote-tracking branch 'origin/master'
Titiftw c76d9e8
PR remarks
Titiftw f85e95a
Display YouTube when presenting, remove line as suggested by PR
Titiftw c240b83
Analysis issues
Titiftw ce31cab
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 24aa0e7
Imports went away
Titiftw 95732b1
Merge branch 'master' of https://github.com/Titiftw/ClassQuiz
Titiftw acf6015
Issue analysis
Titiftw 70811df
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] aec1dce
Tried to simplify function, removed unused arg
Titiftw c1223c0
Merge branch 'master' into feature/fixes
Titiftw 990e328
Merge branch 'feature/fixes'
Titiftw File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,3 +12,4 @@ node_modules/ | |
survey.json | ||
.coverage | ||
export_deta.py | ||
.DS_Store |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see "images_to_delete" being populated. Am I wrong? It seems it's always set to []
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should find the images that were in the quiz before it was saved and deletes them, but I'll check that