Feature/fixes pr #408

Titiftw · 2024-10-17T09:39:20Z

🎩 What? Why?

When playing, there was a bug when a player would reconnect more than once which could potentially happen. I fixed it in my feature branch (now the player can refresh any time the game, as long as it is not answering a question).
When playing, the total score showed on the player screen was wrong if the player reconnected.
When playing, a player could give X answers if it would click X times on the "Validate" button. I adjusted the disabled button logic in the frontend and also return an "already_replied" on the WebSocket.
When playing on a CHECK question, the player could select multiple answers. I made sure all the selected answers were removed when clicking on anoth

Testing

Join a quiz and refresh twice the page. Previously, the second refresh would end up on the Quiz code input.

♥️ Thank you!

View video Wrong if else Issue iframe Edit on the displayed video Small fixes Hide title, better button location Trying to hide title as showinfo no longer works Display video Reverted Music upload File input not declared Removed compressing on musics Issue uploading music Trying to display size & type Images not there Trying stuffs Trying with different object Reverted Added type, corrected filename Display differnt image if music Extra } Updated user storage used Issue in loop Management for music Set music from Library Test blo Audio player Wrong link Trying this Back to list Listing stuffs which are deleted Issue filtering Wrong path set Issue when adding a music to a quizz not being linked to it Wrong var used Debug Debug Debug Blo Debug Magic Reverted Fix in calculate hash I'm banana Remove storage path Calculate hash is bugged Blo Blo Debug Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Blo Log Log Blo Log Log Trying Save item Blo Blo Always delete button Delete button always showed Blo Banana Added player on admin Fix player UI fixes Removed hardcoded blocorp

for more information, see https://pre-commit.ci

# Conflicts: # classquiz/routers/editor.py

This reverts commit 4eab014.

This reverts commit 9d0350c.

This reverts commit 6a5ef05.

This reverts commit be128e1.

This reverts commit da83b9f.

This reverts commit 5c9f2e6.

This reverts commit cf74ae1.

This reverts commit e588779.

This reverts commit 307bb0c.

This reverts commit cc3f1a2.

This reverts commit 06dbd54.

This reverts commit 478e082.

This reverts commit 99d2d22.

for more information, see https://pre-commit.ci

… into feature/fixes-pr

mawoka-myblock · 2024-10-18T10:24:42Z

Please don't create a PR depending on another one. It'll make it even more complex. I'll ignore this PR for now until we figure #401 out if that's fine for you

JasonDavidI8C and others added 30 commits September 25, 2024 17:08

[pre-commit.ci] auto fixes from pre-commit.com hooks

f917e08

for more information, see https://pre-commit.ci

Problem with PR

a35939b

Merge remote-tracking branch 'origin/master'

071ae08

PR remarks

c76d9e8

Display YouTube when presenting, remove line as suggested by PR

f85e95a

Analysis issues

c240b83

[pre-commit.ci] auto fixes from pre-commit.com hooks

ce31cab

for more information, see https://pre-commit.ci

Imports went away

24aa0e7

Merge branch 'master' of https://github.com/Titiftw/ClassQuiz

95732b1

Issue analysis

acf6015

[pre-commit.ci] auto fixes from pre-commit.com hooks

70811df

for more information, see https://pre-commit.ci

Tried to simplify function, removed unused arg

aec1dce

Merge branch 'master' into feature/fixes

c1223c0

# Conflicts: # classquiz/routers/editor.py

Global fixes

f2297a3

Incorrect height while playing

99d2d22

Issue CSS question

478e082

Issue CSS

06dbd54

Trying this change

cc3f1a2

Issue on mobile

307bb0c

Center

e588779

Issue image size

cf74ae1

Max height image 50%

5c9f2e6

Max height image

da83b9f

Still image height issue

be128e1

Issue image gheight

6a5ef05

Again

9d0350c

Added style as input attribute

4eab014

Revert "Added style as input attribute"

409ce53

This reverts commit 4eab014.

Revert "Again"

efad75d

This reverts commit 9d0350c.

Titiftw and others added 18 commits October 17, 2024 11:29

Revert "Issue image gheight"

2c6168b

This reverts commit 6a5ef05.

Revert "Still image height issue"

1557c17

This reverts commit be128e1.

Revert "Max height image"

330cc1f

This reverts commit da83b9f.

Revert "Max height image 50%"

c584923

This reverts commit 5c9f2e6.

Revert "Issue image size"

58157b6

This reverts commit cf74ae1.

Revert "Center"

f570487

This reverts commit e588779.

Revert "Issue on mobile"

3897222

This reverts commit 307bb0c.

Revert "Trying this change"

082382a

This reverts commit cc3f1a2.

Revert "Issue CSS"

511bcb9

This reverts commit 06dbd54.

Revert "Issue CSS question"

0d85586

This reverts commit 478e082.

Revert "Incorrect height while playing"

97d84a2

This reverts commit 99d2d22.

Removed style before PR

5e9eb6f

Missing absolute class

522f782

[pre-commit.ci] auto fixes from pre-commit.com hooks

5a11c99

for more information, see https://pre-commit.ci

Python issues

41eaff3

Merge branch 'feature/fixes-pr' of https://github.com/Titiftw/ClassQuiz…

38dc9cc

… into feature/fixes-pr

Refactored verify answer

85d267c

Using any for abcd answer verification

2e98735

mawoka-myblock marked this pull request as draft October 18, 2024 10:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/fixes pr #408

Feature/fixes pr #408

Titiftw commented Oct 17, 2024

mawoka-myblock commented Oct 18, 2024

Feature/fixes pr #408

Are you sure you want to change the base?

Feature/fixes pr #408

Conversation

Titiftw commented Oct 17, 2024

🎩 What? Why?

Testing

mawoka-myblock commented Oct 18, 2024