Grouped product frontend quantity validation added and code refactor

[Mohamed-Asar]

Description (*)

Grouped Product Frontend Quantity validation added

Related Pull Requests

Fixed Issues (if relevant)

1. Grouped Product Frontend Quantity Validations are Missing #39479
2. Magento 2.4.7 minAllowed missing product order qty  #39142

Manual testing scenarios (*)

1.Create a Grouped Product and associate it with child products.
2. Set the following quantity properties for one of the child products:
- Minimum Qty Allowed in Shopping Cart: 2
- Maximum Qty Allowed in Shopping Cart: 10
- Qty Increments: 2
3.Open the Product Detail Page (PDP) of the Grouped Product and test invalid quantities for the selected child product (e.g., 1, 3, or 11) to confirm that invalid inputs are restricted.

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @Mohamed-Asar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

• @magento run all tests - run or re-run all required tests against the PR changes
• @magento run <test-build(s)> - run or re-run specific test build(s)
  For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:

1. Database Compare
2. Functional Tests CE
3. Functional Tests EE
4. Functional Tests B2B
5. Integration Tests
6. Magento Health Index
7. Sample Data Tests CE
8. Sample Data Tests EE
9. Sample Data Tests B2B
10. Static Tests
11. Unit Tests
12. WebAPI Tests
13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.

---

For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

[Mohamed-Asar]

@magento run all tests.

[magento-automated-testing]

Failed to run the builds. Please try to re-run them later.

[Mohamed-Asar]

@magento run all tests

[Mohamed-Asar]

@magento run all tests

[Mohamed-Asar]

@magento run all tests

[Mohamed-Asar]

@magento run all tests

[Mohamed-Asar]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

@magento run all tests

[engcom-Hotel]

Hello @Mohamed-Asar,

Thanks for updating the PR as per the review comment!

It seems some tests are still failing due to the changes. Please look into those.

Thanks

[Mohamed-Asar]

@magento run all tests

[Mohamed-Asar]

Hello @Mohamed-Asar,

Thanks for updating the PR as per the review comment!

It seems some tests are still failing due to the changes. Please look into those.

Thanks

@engcom-Hotel Do i need to add the dependency in composer.json for this modules( [Magento\InventoryConfigurationApi, Magento\InventorySalesApi]) ? and also these modules are not on this repo, so how can i proceed, do i need to mention in root composer.json and the module composer.json ?

[engcom-Hotel]

@magento run Static Tests

[engcom-Hotel]

Hello @Mohamed-Asar,

I guess you need to mention the dependencies in the composer.json of magento/module-catalog-inventory module here:
https://github.com/Mohamed-Asar/magento2/blob/559d0f8314f93b4aa59562d1a171329242dcffdb/app/code/Magento/CatalogInventory/composer.json#L7-L16

Thanks

[Mohamed-Asar]

@engcom-Hotel i added before, static test failed due to composer dependency issue, please see this commit

after that i removed.

[engcom-Hotel]

@Mohamed-Asar I suggest you to please go through with this documentation: https://developer.adobe.com/commerce/php/architecture/modules/dependencies/

I think we need to add them back.

Thanks

[Mohamed-Asar]

@magento run all tests

[Mohamed-Asar]

@engcom-Hotel I’ve added the module dependency in the CatalogInventory module's composer.json, but the static tests are still failing. It seems we need to add the dependency in the root composer.json file. Would it be okay if I go ahead and add it there as well? Please let me know your suggestion.

Also, I noticed that the following MFTF test is consistently failing. I reviewed the test case and found that it sets min_qty as 4, but tries to add only 1 quantity to the cart—expecting the product to be added successfully.

However, in this PR, I’ve included min_qty validation, which is why the test is failing. Would it be okay if I update the test case accordingly?

Thanks!

[engcom-Hotel]

Hello @Mohamed-Asar,

Regarding the MFTF test failure, yes please update the test. As you resolved the bug related to validation which was not in place previously it might happen some existing tests fails. So generally we need to fix those.

And regarding the composer dependency static test failure we will get back to you soon on this.

Thanks

[Mohamed-Asar]

@magento run all tests

[Mohamed-Asar]

Hi @engcom-Hotel

I fixed the mftf test case for min qty validation