Skip to content

Wishlist validation added for grouped product#39497

Closed
Mohamed-Asar wants to merge 12 commits intomagento:2.4-developfrom
Mohamed-Asar:bug/39496-grouped-product-wishlist-validation
Closed

Wishlist validation added for grouped product#39497
Mohamed-Asar wants to merge 12 commits intomagento:2.4-developfrom
Mohamed-Asar:bug/39496-grouped-product-wishlist-validation

Conversation

@Mohamed-Asar
Copy link
Copy Markdown
Contributor

@Mohamed-Asar Mohamed-Asar commented Dec 20, 2024

Description (*)

Validation added for grouped while add child products to wishlist

Fixed Issues (if relevant)

  1. Fixes Grouped Product Wishlist Validations are not working #39496

Additional Info

This PR depends on this PR

Manual testing scenarios (*)

1.Open grouped product PDP, Fill invalid inputs
3. Click add to wishlist

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • README.md files for modified modules are updated and included in the pull request if any README.md predefined sections require an update
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link
Copy Markdown

m2-assistant Bot commented Dec 20, 2024

Hi @Mohamed-Asar. Thank you for your contribution!
Here are some useful tips on how you can test your changes using Magento test environment.
❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names.

Allowed build names are:
  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests
  13. Semantic Version Checker

You can find more information about the builds here
ℹ️ Run only required test builds during development. Run all test builds before sending your pull request for review.


For more details, review the Code Contributions documentation.
Join Magento Community Engineering Slack and ask your questions in #github channel.

@m2-github-services m2-github-services added Partner: Ziffity partners-contribution Pull Request is created by Magento Partner labels Dec 20, 2024
@m2-community-project m2-community-project Bot added Progress: pending review Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Dec 20, 2024
@engcom-Bravo
Copy link
Copy Markdown
Contributor

Hi @Mohamed-Asar,

Thanks for the collaboration & contribution!

✔️ QA Passed

Preconditions:

  • Install fresh Magento 2.4-develop

Steps to reproduce

  1. Create a Grouped Product and associate it with child products.
  2. Set the following quantity properties for one of the child products:
  • Minimum Qty Allowed in Shopping Cart: 2
  • Maximum Qty Allowed in Shopping Cart: 10
  • Qty Increments: 2
  1. Open grouped product PDP, Don't fill any Qty or fill any invalid inputs like(-1, 3, 11)
  2. Click add to wishlist

Before: ✖️ 

Screenshot 2025-06-24 at 3 17 28 pm Screenshot 2025-06-24 at 3 18 19 pm

After: ✔️

Screenshot 2025-06-24 at 3 52 51 pm Screenshot 2025-06-24 at 3 53 03 pm

Builds are failed. Hence, moving this PR to Extended Testing.

Thanks.

@engcom-Charlie
Copy link
Copy Markdown
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Copy Markdown
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Copy Markdown
Contributor

@magento run Functional Tests B2B, Static Tests, Unit Tests

@engcom-Charlie
Copy link
Copy Markdown
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Copy Markdown
Contributor

@magento run Functional Tests B2B, Functional Tests EE, Static Tests, Unit Tests

@engcom-Charlie
Copy link
Copy Markdown
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Copy Markdown
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Copy Markdown
Contributor

@magento run Functional Tests B2B, Unit Tests

@engcom-Charlie
Copy link
Copy Markdown
Contributor

@magento run all tests

1 similar comment
@engcom-Charlie
Copy link
Copy Markdown
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Copy Markdown
Contributor

@magento run Functional Tests B2B

@engcom-Charlie
Copy link
Copy Markdown
Contributor

@magento run all tests

1 similar comment
@engcom-Charlie
Copy link
Copy Markdown
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Copy Markdown
Contributor

@magento run all tests

@engcom-Charlie
Copy link
Copy Markdown
Contributor

Hi @Mohamed-Asar,

While looking into build failure, we have found that, unit test is failing because of the PR changes with the below error. Can you please have a look into this.

image

Thank you!

@Mohamed-Asar
Copy link
Copy Markdown
Contributor Author

@engcom-Charlie could you please let me know, how can i run the above the test and see the error

@engcom-Charlie
Copy link
Copy Markdown
Contributor

engcom-Charlie commented Jul 28, 2025

@Mohamed-Asar, In order to run javascript unit test on local(here, add-to-wishlist.test.js), you can follow this document.

@engcom-Charlie
Copy link
Copy Markdown
Contributor

Hi @Mohamed-Asar, have you had a chance to look into the failures mentioned in here.

@Mohamed-Asar
Copy link
Copy Markdown
Contributor Author

@engcom-Charlie Not yet, i'll let you know once i fixed

@engcom-Charlie
Copy link
Copy Markdown
Contributor

@engcom-Charlie Not yet, i'll let you know once i fixed

Sure @Mohamed-Asar, till then moving this PR to On hold.

@engcom-Charlie
Copy link
Copy Markdown
Contributor

Hi @Mohamed-Asar, did you get a chance to look into the mentioned failure.

@engcom-Charlie
Copy link
Copy Markdown
Contributor

@Mohamed-Asar, in order to move this PR further, the build should be stable. As mentioned above, the unit test is failing because of the PR change. Currently, I am closing this PR, please feel free to reopen once you done with the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Partner: Ziffity partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: on hold Project: Community Picked PRs upvoted by the community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grouped Product Wishlist Validations are not working

6 participants