Wishlist validation added for grouped product#39497
Wishlist validation added for grouped product#39497Mohamed-Asar wants to merge 12 commits intomagento:2.4-developfrom
Conversation
|
Hi @Mohamed-Asar. Thank you for your contribution!
Allowed build names are:
You can find more information about the builds here For more details, review the Code Contributions documentation. |
|
Hi @Mohamed-Asar, Thanks for the collaboration & contribution! ✔️ QA PassedPreconditions:
Steps to reproduce
Before: ✖️
After: ✔️
Builds are failed. Hence, moving this PR to Extended Testing. Thanks. |
|
@magento run all tests |
|
@magento run all tests |
|
@magento run Functional Tests B2B, Static Tests, Unit Tests |
|
@magento run all tests |
|
@magento run Functional Tests B2B, Functional Tests EE, Static Tests, Unit Tests |
|
@magento run all tests |
|
@magento run all tests |
|
@magento run Functional Tests B2B, Unit Tests |
|
@magento run all tests |
1 similar comment
|
@magento run all tests |
|
@magento run Functional Tests B2B |
|
@magento run all tests |
1 similar comment
|
@magento run all tests |
|
@magento run all tests |
|
Hi @Mohamed-Asar, While looking into build failure, we have found that, unit test is failing because of the PR changes with the below error. Can you please have a look into this.
Thank you! |
|
@engcom-Charlie could you please let me know, how can i run the above the test and see the error |
|
@Mohamed-Asar, In order to run javascript unit test on local(here, add-to-wishlist.test.js), you can follow this document. |
|
Hi @Mohamed-Asar, have you had a chance to look into the failures mentioned in here. |
|
@engcom-Charlie Not yet, i'll let you know once i fixed |
Sure @Mohamed-Asar, till then moving this PR to On hold. |
|
Hi @Mohamed-Asar, did you get a chance to look into the mentioned failure. |
|
@Mohamed-Asar, in order to move this PR further, the build should be stable. As mentioned above, the unit test is failing because of the PR change. Currently, I am closing this PR, please feel free to reopen once you done with the changes. |





Description (*)
Validation added for grouped while add child products to wishlist
Fixed Issues (if relevant)
Additional Info
This PR depends on this PR
Manual testing scenarios (*)
1.Open grouped product PDP, Fill invalid inputs
3. Click add to wishlist
Contribution checklist (*)