Skip to content

Grouped product frontend quantity validation added and code refactor #39480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 25 commits into
base: 2.4-develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f990b58
Grouped product frontend quantity validation added and code refactor
Mohamed-Asar Dec 15, 2024
5f2b740
Merge branch '2.4-develop' into bug/39479-grouped-product-qty-validation
Mohamed-Asar Dec 18, 2024
52bd8e8
Merge branch '2.4-develop' of https://github.com/Mohamed-Asar/magento…
Mohamed-Asar Dec 20, 2024
94fadc8
Ignore item qty validation if zero qty entered in grouped product
Mohamed-Asar Dec 20, 2024
9ac7ef5
Merge branch 'bug/39479-grouped-product-qty-validation' of https://gi…
Mohamed-Asar Dec 20, 2024
eea8ae5
Merge branch '2.4-develop' of https://github.com/Mohamed-Asar/magento…
Mohamed-Asar Dec 30, 2024
a192377
Unit test & static test cases issues fixed
Mohamed-Asar Dec 30, 2024
ceb8597
Static test fixed
Mohamed-Asar Dec 30, 2024
3e0c5a7
Indent issue fixed
Mohamed-Asar Dec 31, 2024
4213997
Merge branch '2.4-develop' into bug/39479-grouped-product-qty-validation
engcom-Hotel Jan 23, 2025
1ca6c6d
Code review changes
Mohamed-Asar Jan 23, 2025
96bfa59
Merge branch '2.4-develop' of https://github.com/Mohamed-Asar/magento…
Mohamed-Asar Feb 18, 2025
cc2409a
Merge branch '2.4-develop' of https://github.com/Mohamed-Asar/magento…
Mohamed-Asar Mar 5, 2025
baeb177
Removed deprecated methods, get data using MSI and unit test added
Mohamed-Asar Mar 7, 2025
9a46f52
Static test case fix
Mohamed-Asar Mar 10, 2025
2e64918
Merge branch '2.4-develop' into bug/39479-grouped-product-qty-validation
engcom-Hotel Mar 11, 2025
b0ad802
Merge branch '2.4-develop' into bug/39479-grouped-product-qty-validation
engcom-Hotel Mar 14, 2025
7545bdb
Merge branch '2.4-develop' into bug/39479-grouped-product-qty-validation
engcom-Hotel Mar 26, 2025
841ffaa
Merge branch '2.4-develop' of https://github.com/Mohamed-Asar/magento…
Mohamed-Asar Apr 3, 2025
559d0f8
Test case failures fix
Mohamed-Asar Apr 3, 2025
8578cb7
Merge branch '2.4-develop' of https://github.com/Mohamed-Asar/magento…
Mohamed-Asar Apr 7, 2025
92c7ad3
Composer dependency added
Mohamed-Asar Apr 7, 2025
0a8daf1
Mftf test case fix for min qty validation
Mohamed-Asar Apr 9, 2025
4a9d850
Merge branch '2.4-develop' of https://github.com/Mohamed-Asar/magento…
Mohamed-Asar Apr 16, 2025
203ba70
Reverted the msi modules approach
Mohamed-Asar Apr 16, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2019 Adobe
* All Rights Reserved.
*/
-->

Expand Down Expand Up @@ -48,7 +48,7 @@
<argument name="value" value="Yes"/>
</actionGroup>
<actionGroup ref="AdminFillAdvancedInventoryQtyActionGroup" stepKey="fillProductQty">
<argument name="qty" value="5"/>
<argument name="qty" value="8"/>
</actionGroup>
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="uncheckMiniQtyCheckBox"/>
<actionGroup ref="AdminSetMinAllowedQtyForProductActionGroup" stepKey="fillMiniAllowedQty">
Expand Down Expand Up @@ -111,17 +111,17 @@
<argument name="productQty" value="4"/>
</actionGroup>
<actionGroup ref="StorefrontAddProductToCartWithQtyActionGroup" stepKey="addAdditionalProductToCart">
<argument name="productQty" value="1"/>
<argument name="productQty" value="4"/>
</actionGroup>
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="seeSuccessSaveMessage"/>
<seeElement selector="{{StorefrontMinicartSection.quantity(6)}}" stepKey="seeAddedProductQuantityInCart"/>
<actionGroup ref="StorefrontClickOnMiniCartActionGroup" stepKey="clickOnMiniCart"/>
<executeJS function="return {{SimpleProduct.price}} * 5" stepKey="expectedCartSubtotal"/>
<executeJS function="return {{SimpleProduct.price}} * 8" stepKey="expectedCartSubtotal"/>
<actionGroup ref="AssertStorefrontMiniCartItemsActionGroup" stepKey="seeProductNameInMiniCart">
<argument name="productName" value="{{SimpleProduct.name}}"/>
<argument name="productPrice" value="{{SimpleProduct.price}}"/>
<argument name="cartSubtotal" value="{$expectedCartSubtotal}" />
<argument name="qty" value="5"/>
<argument name="qty" value="8"/>
</actionGroup>
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="seeProductPriceInMiniCart"/>
<comment userInput="Comment is added to preserve the step key for backward compatibility" stepKey="seeCheckOutButtonInMiniCart"/>
Expand Down
41 changes: 17 additions & 24 deletions app/code/Magento/CatalogInventory/Block/Plugin/ProductView.php
Original file line number Diff line number Diff line change
@@ -1,53 +1,46 @@
<?php
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2015 Adobe
* All Rights Reserved.
*/
namespace Magento\CatalogInventory\Block\Plugin;

use Magento\CatalogInventory\Api\StockRegistryInterface;
use Magento\Catalog\Block\Product\View;
use Magento\CatalogInventory\Model\Product\QuantityValidator;

class ProductView
{
/**
* @var StockRegistryInterface
* @var QuantityValidator
*/
private $stockRegistry;
private $productQuantityValidator;

/**
* @param StockRegistryInterface $stockRegistry
* @param QuantityValidator $productQuantityValidator
*/
public function __construct(
StockRegistryInterface $stockRegistry
QuantityValidator $productQuantityValidator
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use ObjectManager to initialize as this change is BiC.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

) {
$this->stockRegistry = $stockRegistry;
$this->productQuantityValidator = $productQuantityValidator;
}

/**
* Adds quantities validator.
*
* @param \Magento\Catalog\Block\Product\View $block
* @param View $block
* @param array $validators
* @return array
*/
public function afterGetQuantityValidators(
\Magento\Catalog\Block\Product\View $block,
View $block,
array $validators
) {
$stockItem = $this->stockRegistry->getStockItem(
$block->getProduct()->getId(),
$block->getProduct()->getStore()->getWebsiteId()
return array_merge(
$validators,
$this->productQuantityValidator->getData(
$block->getProduct()->getId(),
$block->getProduct()->getStore()->getWebsiteId()
)
);

$params = [];
if ($stockItem->getMaxSaleQty()) {
$params['maxAllowed'] = (float)$stockItem->getMaxSaleQty();
}
if ($stockItem->getQtyIncrements() > 0) {
$params['qtyIncrements'] = (float)$stockItem->getQtyIncrements();
}
$validators['validate-item-quantity'] = $params;

return $validators;
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<?php
/**
* Copyright 2024 Adobe
* All Rights Reserved.
*/
declare(strict_types=1);

namespace Magento\CatalogInventory\Model\Product;

use Magento\CatalogInventory\Api\StockRegistryInterface;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interface StockRegistryInterface has been deprecated. Please use alternate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@engcom-Hotel The alternative for that interface is the MSI module. However, some users might have the MSI module disabled, can i use that ?

Copy link
Contributor

@engcom-Hotel engcom-Hotel Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes @Mohamed-Asar you can use that. BTW its not recommended to disable the MSI module.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@engcom-Hotel MSI module is not included in this repo. how do i proceed ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to this repo: https://github.com/magento/inventory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@engcom-Hotel I used MSI and remvoed the deprecated methods, please review


class QuantityValidator
{
/**
* @param StockRegistryInterface $stockRegistry
*/
public function __construct(
private readonly StockRegistryInterface $stockRegistry
) {
}

/**
* To get quantity validators
*
* @param int $productId
* @param int|null $websiteId
*
* @return array
*/
public function getData(int $productId, int|null $websiteId): array
{
$stockItem = $this->stockRegistry->getStockItem($productId, $websiteId);

$params = [];
$validators = [];
$params['minAllowed'] = $stockItem->getMinSaleQty();
if ($stockItem->getMaxSaleQty()) {
$params['maxAllowed'] = $stockItem->getMaxSaleQty();
}
if ($stockItem->getQtyIncrements() > 0) {
$params['qtyIncrements'] = (float) $stockItem->getQtyIncrements();
}
$validators['validate-item-quantity'] = $params;

return $validators;
}
}

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,72 @@
<?php
/**
* Copyright 2025 Adobe
* All Rights Reserved.
*/
declare(strict_types=1);

namespace Magento\CatalogInventory\Test\Unit\Model\Product;

use Magento\CatalogInventory\Api\StockRegistryInterface;
use Magento\CatalogInventory\Model\Product\QuantityValidator;
use Magento\CatalogInventory\Api\Data\StockItemInterface;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase;

/**
* @covers \Magento\CatalogInventory\Model\Product\QuantityValidator
*/
class QuantityValidatorTest extends TestCase
{
private const PRODUCT_ID = 42;
private const WEBSITE_ID = 1;

/**
* @var QuantityValidator
*/
private $quantityValidator;

/**
* @var StockRegistryInterface|MockObject
*/
private $stockRegistry;

protected function setUp(): void
{
$this->stockRegistry = $this->createMock(StockRegistryInterface::class);

$this->quantityValidator = new QuantityValidator(
$this->stockRegistry
);
}

public function testGetDataWithMinMaxAndIncrements(): void
{
$stockItem = $this->createMock(StockItemInterface::class);

$stockItem->method('getMinSaleQty')
->willReturn(2.0);

$stockItem->method('getMaxSaleQty')
->willReturn(10.0);

$stockItem->method('getQtyIncrements')
->willReturn(2.0);

$this->stockRegistry->expects($this->once())
->method('getStockItem')
->with(self::PRODUCT_ID, self::WEBSITE_ID)
->willReturn($stockItem);

$expected = [
'validate-item-quantity' => [
'minAllowed' => 2.0,
'maxAllowed' => 10.0,
'qtyIncrements' => 2.0
]
];

$result = $this->quantityValidator->getData(self::PRODUCT_ID, self::WEBSITE_ID);
$this->assertEquals($expected, $result);
}
}
4 changes: 2 additions & 2 deletions app/code/Magento/CatalogInventory/etc/module.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?xml version="1.0"?>
<!--
/**
* Copyright © Magento, Inc. All rights reserved.
* See COPYING.txt for license details.
* Copyright 2011 Adobe
* All Rights Reserved.
*/
-->
<config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
Expand Down
46 changes: 46 additions & 0 deletions app/code/Magento/GroupedProduct/ViewModel/ValidateQuantity.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
<?php
/**
* Copyright 2024 Adobe
* All Rights Reserved.
*/
declare(strict_types=1);

namespace Magento\GroupedProduct\ViewModel;

use Magento\CatalogInventory\Model\Product\QuantityValidator;
use Magento\Framework\Serialize\Serializer\Json;
use Magento\Framework\View\Element\Block\ArgumentInterface;

/**
* ViewModel for Grouped Products Block
*/
class ValidateQuantity implements ArgumentInterface
{
/**
* @param Json $serializer
* @param QuantityValidator $productQuantityValidator
*/
public function __construct(
private readonly Json $serializer,
private readonly QuantityValidator $productQuantityValidator,
) {
}

/**
* To get the quantity validators
*
* @param int $productId
* @param int|null $websiteId
*
* @return string
*/
public function getQuantityValidators(int $productId, int|null $websiteId): string
{
return $this->serializer->serialize(
array_merge(
['validate-grouped-qty' => '#super-product-table'],
$this->productQuantityValidator->getData($productId, $websiteId)
)
);
}
}
Loading