Skip to content

test: drain persistence fixtures and cover Claude on Windows - #553

Draft
lidge-jun wants to merge 9 commits into
codex/native-activity-dom-orderfrom
codex/native-activity-persistence-ci
Draft

test: drain persistence fixtures and cover Claude on Windows#553
lidge-jun wants to merge 9 commits into
codex/native-activity-dom-orderfrom
codex/native-activity-persistence-ci

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

Ordinary dependent draft layer above #552; fixture tests, Windows selection and matching documentation only. No production code, dependency, runtime-policy or build configuration change.

  • Drain the real public persistence promises before deleting the two prune-test fixture roots.
  • Verify independent write/delete holds, both completion orders, an event-loop observation checkpoint, and aggregated failures including a falsy rejection.
  • Add five existing Claude SDK test files to the Windows unit selection, preserving all ten prior files and every other workflow value/byte.
  • Document the Windows evidence boundary and shared-singleton fixture isolation.

Source 99513c63caecfab28b0b0aadf548b90a031e1d7d cherry-picked without modification. All three file blobs match the independent R2 review, which passed with no blockers.

Original local validation (348edaf87)

  • 19 manager-lifecycle-persistence tests passed.
  • 104 tests passed across claude-sdk-windows-launch, claude-sdk-session, claude-sdk-control, claude-sdk-core-hardening and claude-sdk-deferred-core.
  • Workflow checker: exact 10 existing +5 added files, all paths exist and are unique; no other parsed value or source byte changed.
  • Line-count check:538 entries passed.

Each file ran with an isolated home and bounded cleanup. No full local suite. These are macOS fixture results, not Windows certification. Actual Windows CI on this exact published head remains required and is tracked asynchronously. No retry/skip/timeout weakening is included.

FS parent refresh (574010a24)

Normally merged updated #552 70fc46c35, retaining the FS/elicitation baseline repair from #551. Fresh 48 tests /4 files passed (three FS files plus all 19 persistence cases). Parent-relative diff remains the original three persistence/workflow/infra files. No production changes. Actual Windows CI is required again on the new head; earlier run results are not relabeled.

Dependency / outstanding gates

Order PR Scope
1 #551 Runtime/Activity integration and baseline oracle repairs
2 #552 Virtual transcript DOM/focus order
3 This PR Persistence fixture drain and Windows SDK coverage

Merge bottom-up only after each required review/CI/impact-QA gate. Remaining parent Web/docs failures and final integrated Electron QA are not waived by this layer. No native stack, old-donor closure, auto-merge, release or deployment.

Windows physical-fixture repair (8368c1d)

Carries the reviewed session-test repair from 8269b2679 in lower #553 and normal parent merges upward. Real held children replace an autonomous 2-second exit; physical factory cleanup uses the unchanged production default budget while synthetic 100ms fixtures remain unchanged. Exit/active-count assertions run immediately at the production return boundary, before an independent close wait; a foreign PONG sentinel verifies sibling preservation.

Fresh scoped verification at this head: 104 tests /5 files passed. The only change from this PR's previous head is claude-sdk-session.test.ts; production termination policy and the complete 15-file Windows selection are unchanged. Actual new-head Windows and Node CI are required and tracked separately. Earlier test/runtime receipts above are not relabeled as fresh runs on this head. No force-push, rebase, skip or gate waiver.

Rendering and bootstrap repair update (05001e4)

Includes the reviewed Node A repair from 916653397: behavioral badge/final-render proofs, actual Mermaid callback dispatch, settings-failure/location ordering and AST-verified API counts. These repairs are present in lower #551 and propagated normally; the required existing replacement tests are retained there. Each layer freshly passed 60 tests across six named files after that update.

Also includes the reviewed Node B repair from be4f5b3b: observable reconnect/history/sidebar readiness, declared HTTP ledgers and an actually-started stale-A request. Model-free/cache/request-bridge repairs start in #551; the newer redirect fixture is repaired only in its existing #554 layer and descendants. No new test is introduced into an earlier layer merely to apply a patch.

Fresh bootstrap verification at this head: 61 tests /6 files passed. The test-only repairs preserve production code, process policy and Windows selection. Exact-head hosted Node/Windows results remain mandatory; previous Windows successes are not relabeled as new-head CI. No whole-suite local run, force-push, rebase, skip or approval bypass.

Shared disconnect repair (1b7c4b1)

This head carries the shared lowest-layer repair through normal parent merges: disconnect cleanup uses the existing synchronous UI import, and a same-stack exact-effect regression preserves every prior oracle. Fresh Node22 focused verification at this head: 80 tests across 5 files, all passed with closed processes and removed owned roots. Historical CI failures remain anchored to their original heads; fresh hosted CI, other runtime reviews and applicable QA are still required. This update is not final merge approval.

Claude cleanup and steer repair (b94bc55)

The shared repair is applied at #551 and normally propagated here. Main acquisition cleanup stays tracked after logical completion; late fulfillment finishes only its captured control and worker directory cleanup remains worker-only. Main, slash fallback and queued steer wait for main accounting without waiting for intentionally surviving workers; inclusive shutdown and exit-settle/salvage order remain intact. Fresh Node22 focused verification at this exact head: 168 tests across 13 files, all passed with observed process closure and owned-root cleanup. No SDK, protocol, permission or delivery-contract expansion. Other runtime/platform reviews, fresh hosted CI and applicable QA remain required; this is not final merge approval.

Pi preparation and cleanup repair (f15755a)

Carries the lowest-layer Pi repair through normal parent merges: one asynchronous completed version observation per RPC gates prompt dispatch while the actual RPC child is returned immediately. Both pool capability getters remain live. Direct Stop and RPC exit start the same bounded paired cleanup; first failure claims its result before draining, and temporary worker deletion requires both immutable physical evidence and captured directory identity. Fresh Node22 focused verification at this exact head passed223 tests across11 files with closed processes and removed owned roots. Typed finality is preserved. The older3s command-availability resolver, opaque/escaped wrapper limitations, aggregate shutdown and actual Windows/provider/native-GUI proof remain distinct limits. Fresh hosted CI and applicable review/QA are still required; no final merge approval.

(cherry picked from commit 99513c63caecfab28b0b0aadf548b90a031e1d7d)
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant