Skip to content

test(web): cover native and print terminal host settlement - #555

Merged
lidge-jun merged 9 commits into
devfrom
codex/native-activity-terminal-host-tests
Sep 7, 2026
Merged

test(web): cover native and print terminal host settlement#555
lidge-jun merged 9 commits into
devfrom
codex/native-activity-terminal-host-tests

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 7, 2026

Copy link
Copy Markdown
Owner

Summary

Ordinary dependent draft above #554. Only two new test files; no production, dependency or runtime-policy change.

  • Cover native terminal host admission, both terminal orders, diagnostics, duplicate delivery, journal gaps, late A/current B ownership and virtual-row recycling.
  • Cover actual accepted print parser → Activity → lifecycle → Web settlement, including exact saved bytes, empty/error output, redacted previews and bounded canonical-record failure.
  • Exercise current MESSAGE/count response envelopes and an exact five-GET discovery/seed/pinned-page/suffix/saved-answer sequence. A separate seq60 tail makes suffix loss observable.
  • Use strict method/path/query/owner fixture checks with positive controls and 68 deliberately rejected requests across four negative cases. Caught unexpected HTTP cannot silently pass.

Source 96f211c3a42c7ac17d1af6c993f27f1544c51785 was cherry-picked unchanged. Both complete file hashes match the independently accepted R2 review, which closed its three earlier fixture-evidence findings. Relevant production and harness files match the reviewed source.

Original NP validation (7c11370cf)

70 tests /7 files passed: web-native-terminal-host13, web-print-activity-settlement26, web-activity-message-hydration11, bounded-api6, print-activity-lifecycle7, print-bypass-paths2 and print-spawn-journal5. Isolated homes and bounded process/output cleanup; no full local suite or build.

The new files contain 33 original scenario vectors plus six HTTP fixture tests. Native canonical packets are synthetic; print producer/lifecycle paths are real but browser transport is ported. No real provider/ACP, EventSource socket, browser geometry/accessibility, IndexedDB, Windows or final Electron certification is claimed. New-head hosted CI is tracked asynchronously; existing parent failures remain open.

Dependency / gates

Manual chain: #551#552#553#554 → this PR. Merge bottom-up only after each applicable review, exact-head CI and impact-QA gate passes. This is not a new native stack. Unready TUI/process-harness work is excluded; no old donor closure, auto-merge, release or deployment.

Windows physical-fixture repair (c4a998d)

Carries the reviewed session-test repair from 8269b2679 in lower #553 and normal parent merges upward. Real held children replace an autonomous 2-second exit; physical factory cleanup uses the unchanged production default budget while synthetic 100ms fixtures remain unchanged. Exit/active-count assertions run immediately at the production return boundary, before an independent close wait; a foreign PONG sentinel verifies sibling preservation.

Fresh scoped verification at this head: 52 tests /2 files passed. The only change from this PR's previous head is claude-sdk-session.test.ts; production termination policy and the complete 15-file Windows selection are unchanged. Actual new-head Windows and Node CI are required and tracked separately. Earlier test/runtime receipts above are not relabeled as fresh runs on this head. No force-push, rebase, skip or gate waiver.

Rendering and bootstrap repair update (5f4e224)

Includes the reviewed Node A repair from 916653397: behavioral badge/final-render proofs, actual Mermaid callback dispatch, settings-failure/location ordering and AST-verified API counts. These repairs are present in lower #551 and propagated normally; the required existing replacement tests are retained there. Each layer freshly passed 60 tests across six named files after that update.

Also includes the reviewed Node B repair from be4f5b3b: observable reconnect/history/sidebar readiness, declared HTTP ledgers and an actually-started stale-A request. Model-free/cache/request-bridge repairs start in #551; the newer redirect fixture is repaired only in its existing #554 layer and descendants. No new test is introduced into an earlier layer merely to apply a patch.

Fresh bootstrap verification at this head: 70 tests /7 files passed. The test-only repairs preserve production code, process policy and Windows selection. Exact-head hosted Node/Windows results remain mandatory; previous Windows successes are not relabeled as new-head CI. No whole-suite local run, force-push, rebase, skip or approval bypass.

Shared disconnect repair (52ba1d8)

This head carries the shared lowest-layer repair through normal parent merges: disconnect cleanup uses the existing synchronous UI import, and a same-stack exact-effect regression preserves every prior oracle. Fresh Node22 focused verification at this head: 80 tests across 5 files, all passed with closed processes and removed owned roots. Historical CI failures remain anchored to their original heads; fresh hosted CI, other runtime reviews and applicable QA are still required. This update is not final merge approval.

Claude cleanup and steer repair (4975d6b)

The shared repair is applied at #551 and normally propagated here. Main acquisition cleanup stays tracked after logical completion; late fulfillment finishes only its captured control and worker directory cleanup remains worker-only. Main, slash fallback and queued steer wait for main accounting without waiting for intentionally surviving workers; inclusive shutdown and exit-settle/salvage order remain intact. Fresh Node22 focused verification at this exact head: 168 tests across 13 files, all passed with observed process closure and owned-root cleanup. No SDK, protocol, permission or delivery-contract expansion. Other runtime/platform reviews, fresh hosted CI and applicable QA remain required; this is not final merge approval.

Pi preparation and cleanup repair (1dd6d37)

Carries the lowest-layer Pi repair through normal parent merges: one asynchronous completed version observation per RPC gates prompt dispatch while the actual RPC child is returned immediately. Both pool capability getters remain live. Direct Stop and RPC exit start the same bounded paired cleanup; first failure claims its result before draining, and temporary worker deletion requires both immutable physical evidence and captured directory identity. Fresh Node22 focused verification at this exact head passed223 tests across11 files with closed processes and removed owned roots. Typed finality is preserved. The older3s command-availability resolver, opaque/escaped wrapper limitations, aggregate shutdown and actual Windows/provider/native-GUI proof remain distinct limits. Fresh hosted CI and applicable review/QA are still required; no final merge approval.

(cherry picked from commit 96f211c3a42c7ac17d1af6c993f27f1544c51785)
@coderabbitai

coderabbitai Bot commented Sep 7, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 3582e1d4-51b8-4de4-8a39-5a12ae4bf17e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 7, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-07T11:24:33.589722Z 698f645 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@lidge-jun
lidge-jun marked this pull request as draft September 7, 2026 11:21
Base automatically changed from codex/native-activity-accessibility-redirect to dev September 7, 2026 11:23
@lidge-jun
lidge-jun merged commit f5cd90a into dev Sep 7, 2026
5 of 9 checks passed
@lidge-jun
lidge-jun deleted the codex/native-activity-terminal-host-tests branch September 7, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant