Skip to content

feat: reconcile native runtime and Activity integration with dev - #551

Draft
lidge-jun wants to merge 195 commits into
devfrom
codex/native-activity-dev-reconcile
Draft

feat: reconcile native runtime and Activity integration with dev#551
lidge-jun wants to merge 195 commits into
devfrom
codex/native-activity-dev-reconcile

Conversation

@lidge-jun

@lidge-jun lidge-jun commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Summary

Runnable cumulative native-runtime / Activity integration candidate, based on dev after #541 and #542. Draft: not ready for final merge.

  • Integrates Grok ACP, optional persistent Claude SDK, Pi typed finality, durable Activity/print compatibility, and web/Manager/TUI consumers with their later ownership and cleanup fixes.
  • Reconciles the already-landed ACP setup-failure fixes through a normal two-parent merge; no history rewrite or wholesale donor replacement.
  • Preserves current integrated production behavior. The initial reconciliation merge changed two regression-test files: conditional trace closure and immediate Cursor/Grok steer termination at the exit barrier. The latest normal-descendant update also replaces stale runtime-settings/error source-shape assertions with behavioral oracles and adds bounded projection-lookup coverage.
  • Preserves legacy transport choices and Slack final-response/ACK/queue contracts.

This PR's dev-to-head diff is cumulative, not a small test-only feature claim. Original donor PRs #543, #544, #545, #546, #547, #548 and #550 remain open while their assertion/path coverage and review dispositions are reconciled; this PR does not claim every donor is fully superseded.

Initial reconciliation verification (36eb07591)

  • 351 tests passed across 20 explicitly selected runtime/trace/transport/request files, including 28 shared ACP setup/cleanup tests.
  • npm run typecheck
  • npm run build --ignore-scripts
  • npm run build:frontend
  • bash scripts/verify-dist-assets.sh
  • bash structure/verify-counts.sh: 538 entries passed.
  • Clean candidate checkout; both integration and current dev heads are actual ancestors.

Tests ran serially with isolated homes and bounded process cleanup. No full local repository suite or real-provider/Slack interaction was performed. An initial test-launch attempt hit macOS IPC socket-path length before tests began; shortening the task-owned temporary prefix fixed the harness, and the complete named run passed. Existing frontend theme-boot/chunk-size warnings remain.

Remaining gates / follow-up layers

Baseline repair update (d15b1c037)

The baseline descendant at d15b1c037 includes the reviewed three-test-file repair from 7725ae600: CSR006/012 now exercise actual settings/session ownership with distinct database sentinels and restoration; EG007's obsolete source window is replaced by the existing, freshly executed EG007a/b print/Copilot error-reentry oracles; three projection-lookup cases guard allocation, recording failure and the item bound. No production code changed in that update.

Freshly passed 76 tests /7 named files on this exact head: cli-switch-refresh, enoent-guard, runtime-projection-lookup, print-spawn-journal, print-bypass-paths, web-settings-runtime-ownership and codex-runtime-projection. New-head CI is tracked separately. This addresses the three known CSR/EG failures, not all remaining Web/docs CI failures. The repair belongs in this lower layer and is normally merged upward into #552; no force-push or rebase.

Final-rendering / hydration baseline update (106ab9f8d)

Source ba49d7470 is included as one three-test-file unit: real finalizer dispatch coverage, six widget types through first-user/history/recycling entrypoints, and removal only of the obsolete elicitation callback assignment-spelling check. All 15 existing elicitation cases remain. Its real first-user/history behavioral replacements are delivered together, not deletion alone. No production change.

Fresh 29 tests /3 files passed on this lower head. The same unit is propagated normally into #552 and #553. Remaining unrelated CI failures still need their own reconciliations; no blanket green claim.

  • Virtual transcript DOM/focus-order reconciliation and donor regression/Windows CI reconciliation.
  • Scope-appropriate independent review and exact-head hosted CI (tracked after publication).
  • Final integrated Electron Computer Use QA after relevant follow-ups; earlier smoke evidence does not certify this final candidate.
  • Final donor disposition and bottom-up integration decisions. No automatic merge, branch deletion, release or deployment is requested.

Further runnable changes will be published as ordinary dependent PR layers; this is not a new GitHub native stack.

Rendering and bootstrap repair update (9712b3d)

Includes the reviewed Node A repair from 916653397: behavioral badge/final-render proofs, actual Mermaid callback dispatch, settings-failure/location ordering and AST-verified API counts. These repairs are present in lower #551 and propagated normally; the required existing replacement tests are retained there. Each layer freshly passed 60 tests across six named files after that update.

Also includes the reviewed Node B repair from be4f5b3b: observable reconnect/history/sidebar readiness, declared HTTP ledgers and an actually-started stale-A request. Model-free/cache/request-bridge repairs start in #551; the newer redirect fixture is repaired only in its existing #554 layer and descendants. No new test is introduced into an earlier layer merely to apply a patch.

Fresh bootstrap verification at this head: 61 tests /6 files passed. The test-only repairs preserve production code, process policy and Windows selection. Exact-head hosted Node/Windows results remain mandatory; previous Windows successes are not relabeled as new-head CI. No whole-suite local run, force-push, rebase, skip or approval bypass.

@coderabbitai

coderabbitai Bot commented Sep 6, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lidge-jun

Copy link
Copy Markdown
Owner Author

Accessibility, visual polish and cross-runtime verification handoff

Verified that all seven scoped checkpoints are ancestors of this PR head 36eb075916ad76bee099c28fc47a671fff06eb4a:

  • 329b1ebd7: stateful composer accessible names
  • fed06b1e2: Pi modal visibility, keyboard containment and focus restoration
  • 48daa301f: narrow header/search/Trace layout containment
  • 7ce874329: Pi typed finality and owned lifecycle settlement
  • ad30739e1: Pi registration response metadata preservation
  • 6adcab80e: configured-policy readout separate from editor drafts
  • 5efff43fc: Stop/delivery contracts and repeated resource cleanup tests

At the integration checkpoint 5efff43fc, 836 tests across 47 explicitly selected files passed, together with server/frontend types, builds, asset checks and architecture counts. Independent review covered the six final test files; its fixture-cleanup finding was repaired and independently rechecked. Controlled browser fixtures exercised keyboard/focus, light/dark narrow layouts, metadata and policy readouts.

These results are checkpoint evidence, not a claim of final-head CI or live-provider certification. This PR head additionally changes native-cursor-setup-errors.test.ts and trace-store.test.ts; its own verification remains the PR owner’s responsibility. Hosted CI is still pending/in progress at this check. Final Electron QA and TUI follow-ups remain with the existing owner. No real Slack delivery, release, deployment or merge is claimed.

All scoped changes are already included here, so no duplicate PR is needed.

(cherry picked from commit 7725ae600061c2d683a0262efffdd1acf4333a39)
(cherry picked from commit fdffa1d81ade44642475e0c309ecfbb32ba4ae65)
(cherry picked from commit ba49d7470cf9d9c6fbb3099f055b04c17a997d16)
(cherry picked from commit 91665339763a4822e65be65a70ed04462adea8d6)
Apply the model-free, cache and request-bridge subset of be4f5b3b2f05754594313e9ef36c6089f25c2417. The newer redirect fixture is repaired at its owning upper layer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant