Adds gradient clipping parameter for distillation using RSL-RL #2454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@ClemensSchwarke This also requires bumping rsl-rl to 2.3.2. @alessandroassirelli98 You'd need to also update the version of rsl-rl in setup.py in |
ClemensSchwarke
requested changes
May 14, 2025
| """The number of environment steps the gradient flows back.""" | ||
|
|
||
| max_grad_norm: None | float = None | ||
| """The maximum gradient norm used for distillation""" |
Collaborator
There was a problem hiding this comment.
Suggested change
| """The maximum gradient norm used for distillation""" | |
| """The maximum norm the gradient is clipped to.""" |
ClemensSchwarke
approved these changes
May 16, 2025
Mayankm96
changed the title
Contributor
|
The pre-commit check is failing. Could you please run |
Contributor
Author
|
yeah sorry, missed an indent 😅 |
Mayankm96
reviewed
Jun 2, 2025
Signed-off-by: Mayank Mittal <[email protected]>
Mayankm96
approved these changes
Jun 2, 2025
fan-ziqi
pushed a commit
to fan-ziqi/IsaacLab
that referenced
this pull request
Jun 5, 2025
…-sim#2454) # Description Added `max_grad_norm` field to `RslRlDistillationAlgorithmCfg` in order to be compatible with leggedrobotics/rsl_rl#91 ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Mayank Mittal <[email protected]> Co-authored-by: alessandro.assirelli <[email protected]> Co-authored-by: Mayank Mittal <[email protected]>
yrh012
pushed a commit
to aica-technology/isaac-lab
that referenced
this pull request
Jun 16, 2025
…-sim#2454) # Description Added `max_grad_norm` field to `RslRlDistillationAlgorithmCfg` in order to be compatible with leggedrobotics/rsl_rl#91 ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Mayank Mittal <[email protected]> Co-authored-by: alessandro.assirelli <[email protected]> Co-authored-by: Mayank Mittal <[email protected]>
harry-wf-cheung
pushed a commit
to harry-wf-cheung/IsaacLab-Harry
that referenced
this pull request
Jul 30, 2025
…-sim#2454) # Description Added `max_grad_norm` field to `RslRlDistillationAlgorithmCfg` in order to be compatible with leggedrobotics/rsl_rl#91 ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Mayank Mittal <[email protected]> Co-authored-by: alessandro.assirelli <[email protected]> Co-authored-by: Mayank Mittal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
max_grad_normfield toRslRlDistillationAlgorithmCfgin order to be compatible with leggedrobotics/rsl_rl#91Type of change
Screenshots
N/A
Checklist
pre-commitchecks with./isaaclab.sh --formatconfig/extension.tomlfileCONTRIBUTORS.mdor my name already exists there