Skip to content

Commit dbaf0d2

Browse files
alessandroassirelli98alessandro.assirelliMayankm96
authored
Adds gradient clipping parameter for distillation using RSL-RL (#2454)
# Description Added `max_grad_norm` field to `RslRlDistillationAlgorithmCfg` in order to be compatible with leggedrobotics/rsl_rl#91 ## Type of change - New feature (non-breaking change which adds functionality) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there --------- Signed-off-by: Mayank Mittal <[email protected]> Co-authored-by: alessandro.assirelli <[email protected]> Co-authored-by: Mayank Mittal <[email protected]>
1 parent ee4e632 commit dbaf0d2

File tree

3 files changed

+5
-1
lines changed

3 files changed

+5
-1
lines changed

CONTRIBUTORS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ Guidelines for modifications:
3535

3636
## Contributors
3737

38+
* Alessandro Assirelli
3839
* Alice Zhou
3940
* Amr Mousa
4041
* Andrej Orsula

source/isaaclab_rl/isaaclab_rl/rsl_rl/distillation_cfg.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,3 +78,6 @@ class RslRlDistillationAlgorithmCfg:
7878

7979
gradient_length: int = MISSING
8080
"""The number of environment steps the gradient flows back."""
81+
82+
max_grad_norm: None | float = None
83+
"""The maximum norm the gradient is clipped to."""

source/isaaclab_rl/setup.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
"sb3": ["stable-baselines3>=2.1"],
4545
"skrl": ["skrl>=1.4.2"],
4646
"rl-games": ["rl-games==1.6.1", "gym"], # rl-games still needs gym :(
47-
"rsl-rl": ["rsl-rl-lib==2.3.1"],
47+
"rsl-rl": ["rsl-rl-lib==2.3.3"],
4848
}
4949
# Add the names with hyphens as aliases for convenience
5050
EXTRAS_REQUIRE["rl_games"] = EXTRAS_REQUIRE["rl-games"]

0 commit comments

Comments
 (0)