Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom verification handler to NIOSSLServerHandler #673

Merged
merged 8 commits into from
Feb 12, 2025

Conversation

adam-fowler
Copy link
Member

No description provided.

@adam-fowler adam-fowler requested a review from Joannis as a code owner February 8, 2025 15:26
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 90.21739% with 9 lines in your changes missing coverage. Please review.

Project coverage is 83.90%. Comparing base (fa528b6) to head (f040581).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ces/HummingbirdHTTP2/TLSChannelConfiguration.swift 50.00% 8 Missing ⚠️
Sources/HummingbirdHTTP2/HTTP2UpgradeChannel.swift 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   83.79%   83.90%   +0.10%     
==========================================
  Files         116      117       +1     
  Lines        7358     7444      +86     
==========================================
+ Hits         6166     6246      +80     
- Misses       1192     1198       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 8, 2025

@adam-fowler adam-fowler requested a review from Joannis February 11, 2025 15:18
Copy link
Member

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This looks great.

@adam-fowler adam-fowler merged commit 567c1fd into main Feb 12, 2025
10 checks passed
@adam-fowler adam-fowler deleted the tls-custom-verification-callback branch February 12, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants