-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow setting NIOSSLCustomVerificationCallback for NIOSSLServerHandler #671
Comments
Perhaps a closure can be passed optionally in the HTTP2ChannelConfiguration or
Or perhaps there is some callback I could use to remove the |
This should be easy enough to add in some form. Let me have a look |
So we have PR #673 which adds a TLSChannelConfiguration to the HTTP2 and TLS channels. This is setting the custom verification but then it never seems to get called. I don't know if you want to test this EDIT: Got the tests working. Forgot to set certificate verification on server TLSConfiguration |
Awesome! I'm working on something else right now, but I'll try to test this soon. |
In 2.9.0 |
Background for why this is useful and when it was added to NIOSSL: apple/swift-nio-ssl#25
Currently there is no way to pass this argument when the NIOSSLServerHandler is created:
hummingbird/Sources/HummingbirdHTTP2/HTTP2UpgradeChannel.swift
Line 94 in c1d1757
Relevant docs on NIOSSLServerHandler:
https://swiftinit.org/docs/swift-nio-ssl/niossl/niosslserverhandler.init(context:customverificationcallback:configuration:)
https://swiftinit.org/docs/swift-nio-ssl/niossl/niosslserverhandler#s:6NIOSSL19NIOSSLServerHandlerC7context26customVerificationCallback13configurationAcA13NIOSSLContextC_ySayAA17NIOSSLCertificateCG_7NIOCore16EventLoopPromiseVyAA24NIOSSLVerificationResultOGtcSgAA13NIOSSLHandlerC13ConfigurationVtcfc
The text was updated successfully, but these errors were encountered: