Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom verification handler to NIOSSLServerHandler #673

Merged
merged 8 commits into from
Feb 12, 2025

Merge branch 'main' into tls-custom-verification-callback

f040581
Select commit
Loading
Failed to load commit list.
Merged

Add custom verification handler to NIOSSLServerHandler #673

Merge branch 'main' into tls-custom-verification-callback
f040581
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 11, 2025 in 0s

83.90% (+0.10%) compared to fa528b6

View this Pull Request on Codecov

83.90% (+0.10%) compared to fa528b6

Details

Codecov Report

Attention: Patch coverage is 90.21739% with 9 lines in your changes missing coverage. Please review.

Project coverage is 83.90%. Comparing base (fa528b6) to head (f040581).

Files with missing lines Patch % Lines
...ces/HummingbirdHTTP2/TLSChannelConfiguration.swift 50.00% 8 Missing ⚠️
Sources/HummingbirdHTTP2/HTTP2UpgradeChannel.swift 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   83.79%   83.90%   +0.10%     
==========================================
  Files         116      117       +1     
  Lines        7358     7444      +86     
==========================================
+ Hits         6166     6246      +80     
- Misses       1192     1198       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.