-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control aloha robot natively #316
Conversation
9b7fb05
to
4044fa9
Compare
4044fa9
to
cd927e1
Compare
2d9c06b
to
b5ad79a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'm going a bit on trust that you've tested this thoroughly as I don't have a robot to try it with.
If there's something you'd like me too look at more deeply, please draw my attention to it.
… per arm, Improve calibration code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on the parts that I was tagged in. Allowing @aliberts to lead this review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great additions, thanks @Cadene.
LGTM with 2 caveats:
- I couldn't try and run the code on any robots as I don't have access rn
- My review is rather shallow as I understand you that want this to be merged quickly
Left some comments, mostly non-blocking but with some questions
Co-authored-by: Simon Alibert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
Co-authored-by: Simon Alibert <[email protected]>
What this does
koch.py
by replacing it with more generalmanipulator.py
lerobot/configs/robot/aloha.yaml
koch
,aloha
) which enable custom robot settings (e.g. torque in leader trigger forkoch
)TODO next PR:
How it was tested
On Koch + Koch bimanual + Aloha:
Also re-read the tutorial to make sure it is up-to-date and compatible with Aloha
How to checkout & try? (for the reviewer)
Koch
Aloha