Skip to content

Conversation

sayakpaul
Copy link
Member

@sayakpaul sayakpaul commented Sep 22, 2025

What does this PR do?

Followup of #12357.

@naykun if you could give this a review.


## Multi-image reference with QwenImageEditPlusPipeline

TODO
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's the speciality of QwenImageEditPlusPipeline, I think we should have a section here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to include an example here for reference? 👀

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Comment on lines +243 to +253
@pytest.mark.xfail(condition=True, reason="Batch of multiple images needs to be revisited", strict=True)
def test_num_images_per_prompt():
super().test_num_images_per_prompt()

@pytest.mark.xfail(condition=True, reason="Batch of multiple images needs to be revisited", strict=True)
def test_inference_batch_consistent():
super().test_inference_batch_consistent()

@pytest.mark.xfail(condition=True, reason="Batch of multiple images needs to be revisited", strict=True)
def test_inference_batch_single_identical():
super().test_inference_batch_single_identical()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naykun these are being xfailed for now because we have to fix how we handle a batch of batch of reference images. For the release, I think that's okay. But LMK.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's fix this after the release~

Copy link
Contributor

@naykun naykun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sayakpaul , changes looks good for me. Is there a way for me to preview the doc?

Comment on lines +243 to +253
@pytest.mark.xfail(condition=True, reason="Batch of multiple images needs to be revisited", strict=True)
def test_num_images_per_prompt():
super().test_num_images_per_prompt()

@pytest.mark.xfail(condition=True, reason="Batch of multiple images needs to be revisited", strict=True)
def test_inference_batch_consistent():
super().test_inference_batch_consistent()

@pytest.mark.xfail(condition=True, reason="Batch of multiple images needs to be revisited", strict=True)
def test_inference_batch_single_identical():
super().test_inference_batch_single_identical()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's fix this after the release~


## Multi-image reference with QwenImageEditPlusPipeline

TODO
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

@sayakpaul
Copy link
Member Author

@naykun sorry I missed the message.

You can preview the docs here:
http://moon-ci-docs.huggingface.co/docs/diffusers/pr_12363/en/api/pipelines/qwenimage

@huggingface huggingface deleted a comment from linoytsaban Sep 22, 2025
@sayakpaul
Copy link
Member Author

@linoytsaban thanks for the reference. I have pushed it. Will merge soon.

@sayakpaul sayakpaul merged commit 5796735 into main Sep 22, 2025
12 checks passed
@sayakpaul sayakpaul deleted the qwenimage-edit-plus-followup branch September 22, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants