-
Notifications
You must be signed in to change notification settings - Fork 6.3k
add test and doc for QwenImageEdit Plus #12363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
||
## Multi-image reference with QwenImageEditPlusPipeline | ||
|
||
TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's the speciality of QwenImageEditPlusPipeline
, I think we should have a section here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you want to include an example here for reference? 👀
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
@pytest.mark.xfail(condition=True, reason="Batch of multiple images needs to be revisited", strict=True) | ||
def test_num_images_per_prompt(): | ||
super().test_num_images_per_prompt() | ||
|
||
@pytest.mark.xfail(condition=True, reason="Batch of multiple images needs to be revisited", strict=True) | ||
def test_inference_batch_consistent(): | ||
super().test_inference_batch_consistent() | ||
|
||
@pytest.mark.xfail(condition=True, reason="Batch of multiple images needs to be revisited", strict=True) | ||
def test_inference_batch_single_identical(): | ||
super().test_inference_batch_single_identical() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naykun these are being xfail
ed for now because we have to fix how we handle a batch of batch of reference images. For the release, I think that's okay. But LMK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's fix this after the release~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sayakpaul , changes looks good for me. Is there a way for me to preview the doc?
@pytest.mark.xfail(condition=True, reason="Batch of multiple images needs to be revisited", strict=True) | ||
def test_num_images_per_prompt(): | ||
super().test_num_images_per_prompt() | ||
|
||
@pytest.mark.xfail(condition=True, reason="Batch of multiple images needs to be revisited", strict=True) | ||
def test_inference_batch_consistent(): | ||
super().test_inference_batch_consistent() | ||
|
||
@pytest.mark.xfail(condition=True, reason="Batch of multiple images needs to be revisited", strict=True) | ||
def test_inference_batch_single_identical(): | ||
super().test_inference_batch_single_identical() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, let's fix this after the release~
|
||
## Multi-image reference with QwenImageEditPlusPipeline | ||
|
||
TODO |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
@naykun sorry I missed the message. You can preview the docs here: |
@linoytsaban thanks for the reference. I have pushed it. Will merge soon. |
What does this PR do?
Followup of #12357.
@naykun if you could give this a review.