maint: add dev notes and update smoke test #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add dedicated DEVELOPING.md for local dev setup and notes, and reference that section in the README. Also update links in README. * Console output is needed for smoke test, but DiagConsoleLogger doesn't seem to be logging as expected, maybe because of the bundler? So for smoke tests right now, use ConsoleSpanExporter. * Sometimes the console output takes longer than the default timeout of 4000ms, so update Cypress config to timeout at 10000ms instead.
JamieDanielson
added
type: maintenance
JamieDanielson
commented
Jan 22, 2024
DEVELOPING.md
Outdated
| # start example app | ||
| npm start | ||
|
|
||
| # after PR 26 |
There was a problem hiding this comment.
If #26 merges first I can update this, otherwise I can come back to this... but wanted to note it while I'm here!
JamieDanielson
commented
Jan 22, 2024
| @@ -1,6 +1,7 @@ | |||
| import { defineConfig } from 'cypress'; | |||
|
|
|||
| export default defineConfig({ | |||
| defaultCommandTimeout: 10000, // default is 4000 | |||
There was a problem hiding this comment.
When running the smoke tests locally the tests would fail with a timeout, so I picked an arbitrary number for now and it's been more reliable
mjayaram
approved these changes
Jan 22, 2024
ahrbnsn
reviewed
Jan 23, 2024
ahrbnsn
reviewed
Jan 23, 2024
pkanal
approved these changes
Jan 23, 2024
just needed to enable Verbose level in the console. Removing the console span exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes
DEVELOPING.mdfor local dev setup and notes, and reference that section in the README. Also update links in README for other docs.How to verify that this has the expected result
Following any of the steps in the DEVELOPING doc work, including the smoke tests.