generated from honeycombio/.github
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maint: add dev notes and update smoke test #28
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,69 @@ | ||
# Local Development | ||
|
||
## Prerequisites | ||
|
||
**Required:** | ||
|
||
- Node.js (minimum version declared in package.json) | ||
|
||
**Recommended:** | ||
|
||
- VSCode Plugins: | ||
- ESLint (dbaeumer.vscode-eslint) | ||
- Prettier (esbenp.prettier-vscode) | ||
- Prettier ESLint (rvest.vs-code-prettier-eslint) | ||
- Docker - Required for running smoke-tests. | ||
- [Docker Desktop](https://www.docker.com/products/docker-desktop/) is a reliable choice if you don't have your own preference. | ||
|
||
## Main Commands | ||
|
||
```shell | ||
# install all dependencies from package.json | ||
npm install | ||
|
||
# compile the typescript source to javascript in a dist directory | ||
npm run build | ||
|
||
# prettier will specify files that need formatting changes | ||
npm run check-format | ||
|
||
# eslint will specify files that have linting errors | ||
npm run lint | ||
|
||
# run unit tests with jest | ||
npm run test | ||
``` | ||
|
||
## Smoke Tests | ||
|
||
Smoke tests currently use Cypress and Docker, and rely on console output. | ||
|
||
```sh | ||
# run smoke tests with cypress and docker | ||
npm run test:smoke | ||
``` | ||
|
||
If it doesn't clean up properly afterward, manually tear it down: | ||
|
||
```sh | ||
npm run clean:smoke-test-example | ||
``` | ||
|
||
## Example Application | ||
|
||
The example app uses a local install of the root directory's code, so make sure that is built first. | ||
|
||
```sh | ||
# navigate to example app | ||
cd ./examples/hello-world-web | ||
|
||
# install dependencies, including local source package | ||
npm install | ||
|
||
# add api key into index.js | ||
|
||
# bundle and run example in watch mode to update when source changes | ||
npm run dev | ||
``` | ||
|
||
To see output in the console in the browser, be sure to enable the console level Verbose in Console Dev Tools. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When running the smoke tests locally the tests would fail with a timeout, so I picked an arbitrary number for now and it's been more reliable