-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maint: 🔧 update example app when honeycomb-opentelemetry-web files change #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm so pumped for this! Going to make dev a lot easier!
"start": "serve .", | ||
"start": "npm run build && serve .", | ||
"watch:build": "chokidar \"../../src/*.ts\" -c \"npm run build\"", | ||
"dev": "npm run start & npm run watch:build", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried this out locally and made a change in src/honeycomb-otel-sdk.ts
and it didn't end up showing up in the app. I can see that it is detecting a change in that file but I think the change isn't showing up because we're not rebuilding at the root level as well as the app level? I don't see the changes rebuilt in the dist folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -8,11 +8,16 @@ You can run this example to see the SDK in action. | |||
|
|||
Paste your API key into `index.js`, where is says "your api key goes here". | |||
|
|||
`npm run build` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can keep this because it's still a viable option, just may be preferred to use the dev option in local dev
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i tweaked the npm run start
command so it calls npm run build
itself, so folks wouldn't have to run both commands before starting up the server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm going to merge, but definitely feel free to ignore & use the current existing setup in your 🔥 local dev instructions in #28
Co-authored-by: Jamie Danielson <[email protected]>
Short description of the changes
Adds
dev
command to the example app. Builds the source js, starts the server, and watcheshoneycomb-opentelemtry-web
files for any changes. When there's a change, re-builds the example app's js.How to verify that this has the expected result
should be running the new code