Split up features. #6905
Split up features. #6905
Conversation
|
The diff that the entire thing has made is slightly confusing, I would recommend reading it separately (or at least |
…ures-main # Conflicts: # wgpu-types/src/lib.rs
# Conflicts: # wgpu-types/src/lib.rs
|
Would be interesting to run cargo-semver-checks against this change, might catch any subtleties missed |
|
one thing I forgot to do so far is to look at the rustdoc output: We need to make sure that this is all still sane and shows the right things. |
I could also not re-export wgpu/webgpu features structs to make users have to use |
|
Why not just call |
No real reason, it was just the name I came up with first. I can call it that if you think it's more clearer though. |
|
I actually prefer |
There was a problem hiding this comment.
thanks for incorporating those improvements. All good to go!
Right now the new features structs aren't exposed through wgpu, I have some experiments locally of what that could look like. I'll create a separate PR for those and ping you on that :)
(alongside with some formatting nits that weren't worth the hold-up - would have pushed to this PR, but for some reason push to PR doesn't work again today, feels kinda random when it does 🙄 )
|
Said follow-up suggestion here |
Splits up features into wgpu & webgpu features.
Connections
Fixes #5247 as this can be infinitely extended (or at least until the stack is exhausted).
Description
Creates an extendable way to use sets of bitflags together. This then splits up features into two subpart: FeaturesWGPU and FeaturesWebGPU. These can be further extended or split if that is needed (e.g shader features vs other features). This is ready for review, tell me if this is the wrong path. I'm quite new to macros (this is probably my second), so tell me if I've missed a helpful feature.
Implementation
Internally this uses a struct as that was the easiest to interact with extendable macros (though externally this interacts with arrays). I think it wouldn't be too hard to switch everything to arrays, but I think it might be slightly messier.
Testing
All existing tests should cover this
Implemented
constFunctionsChecklist
cargo fmt.taplo format.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.