Fix various things so cbindgen works for Firefox (again 😩)
#7132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most important points: - Make macro repetitions easy to parse as a human. - Try to follow `rustfmt` a bit more closely.
cwfitzgerald
requested changes
Feb 14, 2025
wgpu-types/src/features.rs
Outdated
| pub use webgpu_impl::*; | ||
| mod webgpu_impl { | ||
| //! Constant values for [`super::FeaturesWebGPU`], separated so they can be picked up by | ||
| //! `cbindgen` in `mozilla-central` (where Firefix is developed). |
There was a problem hiding this comment.
Firefix is the name of firefox's linting tool (typo)
ErichDonGubler
force-pushed
the
fix-cbindgen-again-ugh
branch
from
921e57e to
2247842
Compare
ErichDonGubler
force-pushed
the
fix-cbindgen-again-ugh
branch
from
2247842 to
4057cc0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRs in the last few weeks have regressed Firefox's usage of
cbindgen, and I'm here to undo the damage without actually reverting them. To wit, I'm aware of these being regressed by:Arc*Descriptorsinto*Descriptors#7056Things still compile and run, so I'm confident things should still work.
Recommended review experience is commit-by-commit. Each individual commit should pass CI! Please merge this with
Rebase and merge.