Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split up features. #6905

Merged
merged 55 commits into from
Feb 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
55 commits
Select commit Hold shift + click to select a range
6f5fb1e
Basic
Vecvec Jan 13, 2025
fea6025
Use bitflags::Flags instead
Vecvec Jan 13, 2025
57e5c3b
make const bits public
Vecvec Jan 13, 2025
507958a
Split up Features.
Vecvec Jan 13, 2025
7048b6f
Implement more `core::ops` (and improve existing).
Vecvec Jan 13, 2025
3c45acb
Merge remote-tracking branch 'refs/remotes/trunk/trunk' into fix-feat…
Vecvec Jan 13, 2025
314b28c
Merge branch 'trunk' into fix-features-main
Vecvec Jan 13, 2025
f47a8cf
Work on docs errors
Vecvec Jan 14, 2025
f57875d
Merge remote-tracking branch 'origin/fix-features-main' into fix-feat…
Vecvec Jan 14, 2025
00e7639
More docs work.
Vecvec Jan 14, 2025
c92e695
Fix docs.
Vecvec Jan 14, 2025
1c8c9ec
Impl. more functions.
Vecvec Jan 14, 2025
f733941
Listen to clippy.
Vecvec Jan 14, 2025
f7c2a4c
Update expected error message to be correct.
Vecvec Jan 14, 2025
fc680eb
Final (main) impls.
Vecvec Jan 14, 2025
c9ce650
Merge branch 'trunk' into fix-features-main
Vecvec Jan 14, 2025
2b09ee4
Implement `from_name`.
Vecvec Jan 14, 2025
9c0503b
Address feedback, get final test to run.
Vecvec Jan 15, 2025
8e2cb85
Clippy no features.
Vecvec Jan 15, 2025
cb10377
Merge branch 'trunk' into fix-features-main
Vecvec Jan 15, 2025
89e1e23
Docs.
Vecvec Jan 16, 2025
edf515d
Merge remote-tracking branch 'trunk/trunk' into fix-features-main
Vecvec Jan 16, 2025
b311e97
Merge branch 'trunk' into fix-features-main
Vecvec Jan 16, 2025
2bbe26d
Merge branch 'trunk' into fix-features-main
Vecvec Jan 16, 2025
2ad9ec3
Fix duplicated instance flags.
Vecvec Jan 16, 2025
b698434
Clippy, format.
Vecvec Jan 16, 2025
19dc2a0
Fix parse hex.
Vecvec Jan 16, 2025
0506a2f
Clippy & format.
Vecvec Jan 16, 2025
4b6f49e
Add `iter` and `iter_names`.
Vecvec Jan 16, 2025
6d75998
Merge branch 'trunk' into fix-features-main
Vecvec Jan 16, 2025
9f36835
Merge branch 'trunk' into fix-features-main
Vecvec Jan 17, 2025
bf2aef1
Merge branch 'trunk' into fix-features-main
Vecvec Jan 20, 2025
7b9fe2f
Merge branch 'trunk' into fix-features-main
Vecvec Jan 22, 2025
24d8f7b
Refine some docs.
Vecvec Jan 17, 2025
0556503
More work on docs.
Vecvec Jan 25, 2025
44105d3
Merge branch 'trunk' into fix-features-main
Vecvec Jan 25, 2025
aae3d1a
Changelog.
Vecvec Jan 25, 2025
fd810bd
Merge branch 'trunk' into fix-features-main
Vecvec Feb 2, 2025
34b16a9
Remove old comments
Vecvec Feb 2, 2025
386015e
Improve changelog
Vecvec Feb 3, 2025
5ec6e09
Rename `Bits` to `FeatureBits`
Vecvec Feb 3, 2025
905ba1a
Correct hex writing.
Vecvec Feb 3, 2025
ac17359
Format & clippy.
Vecvec Feb 3, 2025
8c012cd
Merge branch 'trunk' into fix-features-main
Vecvec Feb 3, 2025
10c66ce
Further testing.
Vecvec Feb 3, 2025
c1b2eee
Add `Features::from_internal_flags`.
Vecvec Feb 4, 2025
901e639
Explain macro better.
Vecvec Feb 4, 2025
2ec3211
Impl empty and all for Flags trait.
Vecvec Feb 4, 2025
e9485bf
Test displaying `Features`.
Vecvec Feb 4, 2025
3f402d6
Use `alloc::format` instead of `core::format`.
Vecvec Feb 5, 2025
73bd27b
Test `bits` functions
Vecvec Feb 5, 2025
df5a2b8
Merge branch 'trunk' into fix-features-main
Vecvec Feb 5, 2025
11f6c9d
Format.
Vecvec Feb 5, 2025
df71bf8
Merge branch 'trunk' into fix-features-main
Vecvec Feb 5, 2025
3665424
Merge branch 'trunk' into fix-features-main
Vecvec Feb 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,15 @@ Bottom level categories:
- Rename `instance_id` and `instance_custom_index` to `instance_index` and `instance_custom_data` by @Vecvec in
[#6780](https://github.com/gfx-rs/wgpu/pull/6780)

##### Split up `Features` internally

Internally split up the `Features` struct and recombine them internally using a macro. There should be no breaking
changes from this. This means there are also namespaces (as well as the old `Features::*`) for all wgpu specific
features and webgpu feature (`FeaturesWGPU` and `FeaturesWebGPU` respectively) and `Features::from_internal_flags` which
allow you to be explicit about whether features you need are available on the web too.

By @Vecvec in [#6905](https://github.com/gfx-rs/wgpu/pull/6905).

##### Refactored internal trace path parameter

Refactored some functions to handle the internal trace path as a string to avoid possible issues with `no_std` support.
Expand Down
2 changes: 1 addition & 1 deletion tests/tests/device.rs
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ async fn request_device_error_message() {
let expected = "TypeError";
} else {
// This message appears whenever wgpu-core is used as the implementation.
let expected = "Unsupported features were requested: Features(";
let expected = "Unsupported features were requested: Features {";
}
}
assert!(device_error.contains(expected), "{device_error}");
Expand Down
Loading