[ENH/WIP] Adding first test to implement marching cubes #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To keep working in this PR you just need to checkout this branch and push the changes Step I: Monolithic code extracting meshes@javoha as far I understood you pretty much have this code. Just add it in the test so we can later extract the functions that we will need to put somewhere else and find out the data structures that we will need Step II: Extracting functions and data classes and place them in the right location @Leguark |
Leguark
changed the title
|
Hi, |
|
great thanks. I will take a look at simplifying it as I extract code into functions and put it in the right location. I will try to come around this week. |
Leguark
force-pushed
the
adding_marching_cubes
branch
from
07f6981 to
7cba374
Compare
4 tasks
4 tasks
4 tasks
Leguark
added a commit
that referenced
this pull request
May 2, 2025
# Description Since the release of gempy v3 we noticed some outliers in the lithology block. These are basically single cells that have a wrong element ID in the lithology block. They generally appear close to surface boundaries and are appearing depending on resolution. This might be caused when mapping sclar field values to int for the lithology block. As I don't think the isse is related to Octrees or DC I opened a new pull request. This issue will cause problems when reintroducing MC as a meshing approach in #1000 and #1006 . For now I added a single example as a test (see screenshot). I will add more examples whe I come across them and have time.  # Checklist - [ ] My code uses type hinting for function and method arguments and return values. - [x] I have created tests which cover my code. - [x] The test code either 1. demonstrates at least one valuable use case (e.g. integration tests) or 2. verifies that outputs are as expected for given inputs (e.g. unit tests). - [ ] New tests pass locally with my changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implementing marching cubes
Relates to
Checklist
or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).