Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Outliers in gempy v3 #1009

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[BUG] Outliers in gempy v3 #1009

wants to merge 1 commit into from

Conversation

javoha
Copy link
Member

@javoha javoha commented Mar 26, 2025

Description

Since the release of gempy v3 we noticed some outliers in the lithology block. These are basically single cells that have a wrong element ID in the lithology block. They generally appear close to surface boundaries and are appearing depending on resolution. This might be caused when mapping sclar field values to int for the lithology block.
As I don't think the isse is related to Octrees or DC I opened a new pull request. This issue will cause problems when reintroducing MC as a meshing approach in #1000 and #1006 .

For now I added a single example as a test (see screenshot). I will add more examples whe I come across them and have time.

image

Checklist

  • My code uses type hinting for function and method arguments and return values.
  • I have created tests which cover my code.
  • The test code either 1. demonstrates at least one valuable use case (e.g. integration tests)
    or 2. verifies that outputs are as expected for given inputs (e.g. unit tests).
  • New tests pass locally with my changes.

@graphite-app graphite-app bot added the gempy 3 Will come with the next major update label Mar 26, 2025
Copy link

graphite-app bot commented Mar 26, 2025

Graphite Automations

"Add gempy label" took an action on this PR • (03/26/25)

1 label was added to this PR based on Miguel de la Varga's automation.

@AlexanderJuestel
Copy link
Contributor

Yeah, I have noticed that issue as well. Had some additional lith ids there suddenly

@javoha javoha changed the title Outliers in gempy v3 [BUG] Outliers in gempy v3 Mar 27, 2025
@javoha
Copy link
Member Author

javoha commented Mar 27, 2025

Yeah, I have noticed that issue as well. Had some additional lith ids there suddenly

Hi @AlexanderJuestel, just to make sure - did you encounter completely new IDs? So far I have only seen existing elements out of place (like in the screenshot above).

@AlexanderJuestel
Copy link
Contributor

I have actually encountered new IDs

Copy link
Member

Leguark commented Mar 30, 2025

Thanks for opening this. This makes so much easier to chase these things. For now I mark it as draft since it is not meant to be reviewed.

@Leguark Leguark marked this pull request as draft March 30, 2025 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gempy 3 Will come with the next major update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants