Skip to content

Clean up temporary home directory to make tests more robust #3146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 23, 2025
Merged

Clean up temporary home directory to make tests more robust #3146

merged 2 commits into from
Oct 23, 2025

Conversation

@azeey
Copy link
Contributor

@azeey azeey commented Oct 23, 2025

🦟 Bug fix

Fixes #3031

Summary

I think I know what the issue is with the UtilTest.ResolveSdfWorldFile test. It appears that the temporary directory created for Fuel caches in the tests are not cleared properly. It's also not clear if these are being created on in-memory file system on macOS, which means they persist across reboots.

  • As a result of this, the test is not running properly. It is not downloading the test world every time. Instead, it's using cached files which might be corrupt.
  • I reproduced a similar test failure by going into the cache location and only removing the test.sdf file.

This patch cleans up the temporary home directory when each test is done.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.

@azeey azeey requested a review from arjo129 as a code owner October 23, 2025 03:36
arjo129
arjo129 approved these changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change.

@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Oct 23, 2025
@arjo129
Copy link
Contributor

arjo129 commented Oct 23, 2025

There seem to be some regressions in the logging system test.

@azeey
Remove expectation that auto_default.log will exist
aac799e 
This file only exists if the GUI has run. Since each test now starts
with a clean ".gz" directory, this file will not exist when this test
runs.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey merged commit 83a6331 into gazebosim:main Oct 23, 2025
13 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Oct 23, 2025
@azeey
Copy link
Contributor Author

azeey commented Oct 23, 2025

@Mergifyio backport gz-sim10 gz-sim9 gz-sim8 ign-gazebo6

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2025 •
edited
Loading

backport gz-sim10 gz-sim9 gz-sim8 ign-gazebo6

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Oct 23, 2025
@azeey @mergify
Clean up temporary home directory to make tests more robust (#3146)
62adcc2 
* Clean up temporary home directory to make tests more robust

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Remove expectation that auto_default.log will exist

This file only exists if the GUI has run. Since each test now starts
with a clean ".gz" directory, this file will not exist when this test
runs.

Signed-off-by: Addisu Z. Taddese <[email protected]>

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 83a6331)
mergify bot pushed a commit that referenced this pull request Oct 23, 2025
@azeey @mergify
Clean up temporary home directory to make tests more robust (#3146)
bf3dcf3 
* Clean up temporary home directory to make tests more robust

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Remove expectation that auto_default.log will exist

This file only exists if the GUI has run. Since each test now starts
with a clean ".gz" directory, this file will not exist when this test
runs.

Signed-off-by: Addisu Z. Taddese <[email protected]>

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 83a6331)
mergify bot pushed a commit that referenced this pull request Oct 23, 2025
@azeey @mergify
Clean up temporary home directory to make tests more robust (#3146)
c4dbca6 
* Clean up temporary home directory to make tests more robust

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Remove expectation that auto_default.log will exist

This file only exists if the GUI has run. Since each test now starts
with a clean ".gz" directory, this file will not exist when this test
runs.

Signed-off-by: Addisu Z. Taddese <[email protected]>

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 83a6331)
This was referenced Oct 23, 2025
Merged
Merged
Merged
mergify bot pushed a commit that referenced this pull request Oct 23, 2025
@azeey @mergify
Clean up temporary home directory to make tests more robust (#3146)
27a8809 
* Clean up temporary home directory to make tests more robust

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Remove expectation that auto_default.log will exist

This file only exists if the GUI has run. Since each test now starts
with a clean ".gz" directory, this file will not exist when this test
runs.

Signed-off-by: Addisu Z. Taddese <[email protected]>

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 83a6331)

# Conflicts:
#	test/integration/log_system.cc
@mergify mergify bot mentioned this pull request Oct 23, 2025
Open
9 tasks
azeey added a commit that referenced this pull request Oct 24, 2025
@azeey
Clean up temporary home directory to make tests more robust (#3146)
275e881 
* Clean up temporary home directory to make tests more robust

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Remove expectation that auto_default.log will exist

This file only exists if the GUI has run. Since each test now starts
with a clean ".gz" directory, this file will not exist when this test
runs.

Signed-off-by: Addisu Z. Taddese <[email protected]>

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 83a6331)
azeey added a commit that referenced this pull request Oct 24, 2025
@azeey
Clean up temporary home directory to make tests more robust (#3146)
53aa656 
* Clean up temporary home directory to make tests more robust

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Remove expectation that auto_default.log will exist

This file only exists if the GUI has run. Since each test now starts
with a clean ".gz" directory, this file will not exist when this test
runs.

Signed-off-by: Addisu Z. Taddese <[email protected]>

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 83a6331)
azeey added a commit that referenced this pull request Nov 6, 2025
@azeey
Clean up temporary home directory to make tests more robust (#3146)
e8a30cf 
* Clean up temporary home directory to make tests more robust

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Remove expectation that auto_default.log will exist

This file only exists if the GUI has run. Since each test now starts
with a clean ".gz" directory, this file will not exist when this test
runs.

Signed-off-by: Addisu Z. Taddese <[email protected]>

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 83a6331)
azeey added a commit that referenced this pull request Nov 7, 2025
@azeey
Clean up temporary home directory to make tests more robust (#3146)
b4da463 
* Clean up temporary home directory to make tests more robust

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Remove expectation that auto_default.log will exist

This file only exists if the GUI has run. Since each test now starts
with a clean ".gz" directory, this file will not exist when this test
runs.

Signed-off-by: Addisu Z. Taddese <[email protected]>

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 83a6331)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arjo129 arjo129 arjo129 approved these changes

@iche033 iche033 iche033 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Core development
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@azeey @arjo129 @iche033