Clean up temporary home directory to make tests more robust (backport #3146) #3149
+4
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Contributor
|
@Mergifyio rebase |
* Clean up temporary home directory to make tests more robust Signed-off-by: Addisu Z. Taddese <[email protected]> * Remove expectation that auto_default.log will exist This file only exists if the GUI has run. Since each test now starts with a clean ".gz" directory, this file will not exist when this test runs. Signed-off-by: Addisu Z. Taddese <[email protected]> --------- Signed-off-by: Addisu Z. Taddese <[email protected]> (cherry picked from commit 83a6331)
Contributor
Author
✅ Branch has been successfully rebased |
azeey
force-pushed
the
mergify/bp/gz-sim10/pr-3146
branch
from
c4dbca6 to
e8a30cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #3031
Summary
I think I know what the issue is with the
UtilTest.ResolveSdfWorldFiletest. It appears that the temporary directory created for Fuel caches in the tests are not cleared properly. It's also not clear if these are being created on in-memory file system on macOS, which means they persist across reboots.test.sdffile.This patch cleans up the temporary home directory when each test is done.
Checklist
codecheckpassed (See contributing)Generated-by: Remove this if GenAI was not used.
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-byandGenerated-bymessages.This is an automatic backport of pull request #3146 done by [Mergify](https://mergify.com).