Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Oct 23, 2025

🦟 Bug fix

Fixes #3031

Summary

I think I know what the issue is with the UtilTest.ResolveSdfWorldFile test. It appears that the temporary directory created for Fuel caches in the tests are not cleared properly. It's also not clear if these are being created on in-memory file system on macOS, which means they persist across reboots.

  • As a result of this, the test is not running properly. It is not downloading the test world every time. Instead, it's using cached files which might be corrupt.
  • I reproduced a similar test failure by going into the cache location and only removing the test.sdf file.

This patch cleans up the temporary home directory when each test is done.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers
  • Was GenAI used to generate this PR? If so, make sure to add "Generated-by" to your commits. (See this policy for more info.)

Generated-by: Remove this if GenAI was not used.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by and Generated-by messages.


This is an automatic backport of pull request #3146 done by [Mergify](https://mergify.com).

* Clean up temporary home directory to make tests more robust

Signed-off-by: Addisu Z. Taddese <[email protected]>

* Remove expectation that auto_default.log will exist

This file only exists if the GUI has run. Since each test now starts
with a clean ".gz" directory, this file will not exist when this test
runs.

Signed-off-by: Addisu Z. Taddese <[email protected]>

---------

Signed-off-by: Addisu Z. Taddese <[email protected]>
(cherry picked from commit 83a6331)

# Conflicts:
#	test/integration/log_system.cc
@mergify
Copy link
Contributor Author

mergify bot commented Oct 23, 2025

Cherry-pick of 83a6331 has failed:

On branch mergify/bp/ign-gazebo6/pr-3146
Your branch is up to date with 'origin/ign-gazebo6'.

You are currently cherry-picking commit 83a6331a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   test/helpers/EnvTestFixture.hh

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   test/integration/log_system.cc

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Inbox

Development

Successfully merging this pull request may close these issues.

2 participants