refactor: 디자인 토큰 폴더 및 워크플로우 수정#46
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 본 PR은 디자인 토큰 관리 방식의 효율성을 높이기 위한 리팩토링을 수행합니다. 기존의 분산된 토큰 파일 구조를 단일 파일로 통합하여 관리 편의성을 개선하고, 관련 설정 및 워크플로우를 최신 상태로 조정하였습니다. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. 토큰들이 모여 하나가 되니, 디자인의 질서가 바로 서네. 복잡한 폴더는 이제 안녕, 간결한 코드로 다시 태어나네. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request consolidates design tokens into a single tokens.json file and updates the Style Dictionary configuration to point to this file. The reviewer suggests reverting to glob patterns for the source configuration to improve maintainability and notes that the workflow modifications mentioned in the PR description are missing from the changes.
|
|
||
| const sd = new StyleDictionary({ | ||
| source: ['tokens/**/*.json', '!tokens/$metadata.json'], | ||
| source: ['tokens/tokens.json'], |
|
|
||
| const sd = new StyleDictionary({ | ||
| source: ['tokens/**/*.json', '!tokens/$metadata.json'], | ||
| source: ['tokens/tokens.json'], |
There was a problem hiding this comment.
Pull Request
관련 이슈
작업 내용
참고 사항
체크리스트