Skip to content

refactor: 디자인 토큰 폴더 및 워크플로우 수정 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wlrnjs merged 1 commit into from
May 11, 2026
Merged

refactor: 디자인 토큰 폴더 및 워크플로우 수정 #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions .github/workflows/build-design-tokens.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ jobs:

- name: Setup pnpm
uses: pnpm/action-setup@v4
with:
version: 9

- name: Setup Node
uses: actions/setup-node@v4
Expand Down
2 changes: 1 addition & 1 deletion packages/design-tokens/sd.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ StyleDictionary.registerFormat({
});

const sd = new StyleDictionary({
source: ['tokens/**/*.json', '!tokens/$metadata.json'],
source: ['tokens/tokens.json'],
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

PR 제목 및 설명에 명시된 '워크플로우 수정(버전 수정)' 관련 변경 사항이 실제 diff 내역에 포함되어 있지 않습니다. .github/workflows 폴더 내의 YAML 파일 등 누락된 파일이 있는지 확인이 필요합니다.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Style Dictionary의 source 설정을 특정 파일명(tokens.json)으로 고정하기보다 glob 패턴을 사용하는 것이 유지보수 측면에서 더 유리합니다. 파일명이 변경되거나 나중에 토큰 파일이 추가되더라도 설정을 매번 수정할 필요가 없으며, Tokens Studio에서 생성될 수 있는 $metadata.json 파일을 자동으로 제외하는 기존 로직을 유지할 수 있습니다.

  source: ['tokens/**/*.json', '!tokens/$metadata.json'],

preprocessors: ['tokens-studio'],
platforms: {
css: {
Expand Down
3 changes: 0 additions & 3 deletions packages/design-tokens/tokens/$metadata.json
View file
Open in desktop

This file was deleted.

16 changes: 0 additions & 16 deletions packages/design-tokens/tokens/colors.json
View file
Open in desktop

This file was deleted.

14 changes: 14 additions & 0 deletions ...ages/design-tokens/tokens/typography.json → packages/design-tokens/tokens/tokens.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,18 @@
{
"color": {
"primary": { "value": "#3B82F6", "type": "color" },
"primary-hover": { "value": "#2563EB", "type": "color" },
"secondary": { "value": "#8B5CF6", "type": "color" },
"surface": { "value": "#F8FAFC", "type": "color" },
"surface-elevated": { "value": "#FFFFFF", "type": "color" },
"text-default": { "value": "#111827", "type": "color" },
"text-muted": { "value": "#6B7280", "type": "color" },
"text-inverse": { "value": "#FFFFFF", "type": "color" },
"border": { "value": "#E5E7EB", "type": "color" },
"success": { "value": "#10B981", "type": "color" },
"warning": { "value": "#F59E0B", "type": "color" },
"error": { "value": "#EF4444", "type": "color" }
},
"font-size": {
"xl": { "value": "2rem", "type": "fontSizes" },
"lg": { "value": "1.5rem", "type": "fontSizes" },
Expand Down
Loading