Skip to content

[배포 대기] main 최신화#43

Open
wlrnjs wants to merge 24 commits into
mainfrom
develop
Open

[배포 대기] main 최신화#43
wlrnjs wants to merge 24 commits into
mainfrom
develop

Conversation

@wlrnjs
Copy link
Copy Markdown
Member

@wlrnjs wlrnjs commented May 9, 2026 •
edited
Loading

작업 요약

Develop 브랜치의 최신 변경 사항을 Main 브랜치로 반영합니다.

최근 머지된 내역

@wlrnjs wlrnjs added the main main 브랜치를 최신 상태로 동기화하는 작업 label May 9, 2026
@auto-assign auto-assign Bot requested a review from junye0l May 9, 2026 09:28
@vercel
Copy link
Copy Markdown

vercel Bot commented May 9, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
finditem-monitoring Ready Ready Preview, Comment May 14, 2026 1:31am

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist Bot commented May 9, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

본 PR은 프로젝트의 폴더 구조를 표준화하고 정리하기 위한 리팩토링 작업을 포함하고 있습니다. 주요 변경 사항은 페이지별 디렉토리 내의 내부 모듈 폴더들을 언더스코어 접두사로 통일하는 것이며, 이에 따른 경로 참조 수정 및 타입 임포트 최적화가 진행되었습니다.

Highlights

  • 폴더 구조 리팩토링: 각 페이지별로 구성된 hooks, types, utils 폴더를 _hooks, _types, _utils와 같이 언더스코어 접두사가 붙은 폴더로 일괄 변경하여 프로젝트 구조를 정비했습니다.
  • 임포트 경로 및 타입 수정: 폴더명 변경에 따른 모든 파일 내 임포트 경로를 업데이트하고, 타입 임포트 시 type 키워드를 명시하여 최적화했습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

폴더를 옮겨 정리하니, 코드가 한결 깔끔해졌네. 경로를 따라 찾아가 보니, 구조가 한눈에 들어오네.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist Bot reviewed May 9, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames internal page directories (such as hooks and types) to use an underscore prefix (e.g., _hooks, _types) to indicate they are private to the page. The review feedback points out that importing these private types into global query files violates encapsulation and suggests moving shared types to a common directory like src/types or the specific query domain folder to reduce coupling.

Comment thread apps/monitor-web/src/queries/login/login.queries.ts
import useAppMutation from "../base/useAppMutation";
import { LoginFormValues } from "@/pages/Login/types";
import { useQueryClient } from "@tanstack/react-query";
import type { LoginFormValues } from "@/pages/Login/_types";
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

_ 접두사가 붙은 폴더(_types)는 일반적으로 해당 페이지 내에서만 사용되는 내부(private) 모듈임을 의미합니다. 글로벌 영역인 src/queries에서 특정 페이지 내부의 _types를 직접 참조하는 것은 캡슐화를 해치고 페이지 구조에 대한 강한 의존성을 만듭니다. LoginFormValues와 같이 여러 곳에서 공유가 필요한 타입은 src/types나 해당 쿼리 도메인 폴더(예: src/queries/login/types.ts)로 이동하여 관리하는 것을 권장합니다.

wlrnjs added 2 commits May 12, 2026 01:28
@wlrnjs
test commit
71ad100
@wlrnjs
Merge pull request #47 from finditem/design-tokens
b727dd5 
feat: 디자인 토큰 자동화 테스트
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@junye0l junye0l Awaiting requested review from junye0l

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@wlrnjs wlrnjs

Labels

main main 브랜치를 최신 상태로 동기화하는 작업

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wlrnjs