Update the manifest for the Waveshare ESP32-S3-Zero board#1640
Conversation
|
|
esphbot
left a comment
There was a problem hiding this comment.
Blocking issues found.
- RGB LED mapped to wrong pin — WS2812 is on GPIO21, not GPIO38
- GPIO15 has no touch — "Touch12" note is wrong and duplicated
- GPIO0 dropped from the pin list — confirm it is genuinely not exposed
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1640 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 227 227
Lines 18129 18129
=======================================
Hits 18047 18047
Misses 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
- Correction for the onboard RGB led to pin 21. - Confirmed GPIO0 has no external connection, except to BOOT button
Removed touch feature from GPIO15 and updated notes for GPIO15 and GPIO16.
|
|
esphbot
left a comment
There was a problem hiding this comment.
Blocking issues found.
- Generated body JSON is out of sync with the manifest — not regenerated
Run script/sync_boards.py so the shipped body JSON matches the corrected manifest, and drop a stray leading space in the GPIO47 note.
PR Review — Update the manifest for the Waveshare ESP32-S3-Zero boardSolid, factually-corrected board manifest update. The prior blocking reviews are stale — the body JSON has been regenerated and is now in sync with the manifest. What's done well:
The two existing
🟢 Suggestions
1. Image is a MediaWiki thumbnail path — prefer a more durable source
|
esphbot
left a comment
There was a problem hiding this comment.
No blocking issues found.
What does this implement/fix?
Update the manifest for the Waveshare ESP32-S3-Zero board.
Related issue or feature (if applicable):
none
Types of changes
bugfixnew-featureenhancementbreaking-changerefactordocsmaintenancecidependenciesFrontend coordination
Checklist
ruff,codespell, yaml/json/python checks).tests/where applicable.components.index.json/definitions/components/*.jsonhave not been hand-edited (regenerate viascript/sync_components.pyif a sync is needed).docs/ARCHITECTURE.mdand/ordocs/API.md.