Update the Waveshare ESP32-S3-Zero board manifest#1652
Closed
bdraco wants to merge 1 commit into
Closed
Conversation
Correct the hardware facts (4 MB flash, 2 MB PSRAM, board size), move the WS2812 RGB LED to GPIO21, mark the unbroken-out pins unavailable, and regenerate the body/index via script/sync_boards.py so the shipped JSON matches the manifest.
Member
Author
|
Superseded; pushed the regeneration fix directly to #1640 instead. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1652 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 227 227
Lines 18129 18129
=======================================
Hits 18047 18047
Misses 82 82
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Updates the Waveshare ESP32-S3-Zero board manifest with the correct hardware facts (4 MB flash, 2 MB PSRAM, 18x23.5mm), moves the onboard WS2812 RGB LED to GPIO21, and marks the pins that are not broken out as unavailable. The body JSON and index are regenerated from the manifest with
script/sync_boards.pyso the shipped catalog matches the manifest; this finishes the work in #1640, where the generated files were out of sync.Related issue or feature (if applicable):
Types of changes
bugfixnew-featureenhancementbreaking-changerefactordocsmaintenancecidependenciesFrontend coordination
Checklist
ruff,codespell, yaml/json/python checks).tests/where applicable.components.index.json/definitions/components/*.jsonhave not been hand-edited (regenerate viascript/sync_components.pyif a sync is needed).docs/ARCHITECTURE.mdand/ordocs/API.md.