Skip to content

Update the Waveshare ESP32-S3-Zero board manifest#1652

Closed
bdraco wants to merge 1 commit into
mainfrom
waveshare-esp32-s3-zero-manifest
Closed

Update the Waveshare ESP32-S3-Zero board manifest#1652
bdraco wants to merge 1 commit into
mainfrom
waveshare-esp32-s3-zero-manifest

Conversation

@bdraco

@bdraco bdraco commented Jun 22, 2026

Copy link
Copy Markdown
Member

What does this implement/fix?

Updates the Waveshare ESP32-S3-Zero board manifest with the correct hardware facts (4 MB flash, 2 MB PSRAM, 18x23.5mm), moves the onboard WS2812 RGB LED to GPIO21, and marks the pins that are not broken out as unavailable. The body JSON and index are regenerated from the manifest with script/sync_boards.py so the shipped catalog matches the manifest; this finishes the work in #1640, where the generated files were out of sync.

Related issue or feature (if applicable):

Types of changes

  • Bugfix (non-breaking change which fixes an issue) — bugfix
  • New feature (non-breaking change which adds functionality) — new-feature
  • Enhancement to an existing feature — enhancement
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) — breaking-change
  • Refactor (no behaviour change) — refactor
  • Documentation only — docs
  • Maintenance / chore — maintenance
  • CI / workflow change — ci
  • Dependencies bump — dependencies

Frontend coordination

  • No frontend change needed
  • Companion frontend PR: esphome/device-builder-frontend#

Checklist

  • The code change is tested and works locally.
  • Pre-commit hooks pass (ruff, codespell, yaml/json/python checks).
  • Tests have been added or updated under tests/ where applicable.
  • components.index.json / definitions/components/*.json have not been hand-edited (regenerate via script/sync_components.py if a sync is needed).
  • Architecture-level changes are reflected in docs/ARCHITECTURE.md and/or docs/API.md.

Correct the hardware facts (4 MB flash, 2 MB PSRAM, board size), move the
WS2812 RGB LED to GPIO21, mark the unbroken-out pins unavailable, and
regenerate the body/index via script/sync_boards.py so the shipped JSON
matches the manifest.
@bdraco bdraco added the enhancement Improvement to an existing feature label Jun 22, 2026
@bdraco

bdraco commented Jun 22, 2026

Copy link
Copy Markdown
Member Author

Superseded; pushed the regeneration fix directly to #1640 instead.

@bdraco bdraco closed this Jun 22, 2026
@bdraco bdraco deleted the waveshare-esp32-s3-zero-manifest branch June 22, 2026 15:02
@codspeed-hq

codspeed-hq Bot commented Jun 22, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 27 untouched benchmarks


Comparing waveshare-esp32-s3-zero-manifest (f90a1f3) with main (bae05a2)

Open in CodSpeed

@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.54%. Comparing base (bae05a2) to head (f90a1f3).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1652   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files         227      227           
  Lines       18129    18129           
=======================================
  Hits        18047    18047           
  Misses         82       82           
Flag Coverage Δ
py3.12 99.52% <ø> (ø)
py3.14 99.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improvement to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant