Fix ember 7 support#796
Closed
NullVoxPopuli wants to merge 29 commits into
Closed
Conversation
4 tasks
SergeAstapov
approved these changes
May 8, 2026
…m 'ember'`
Two changes:
1. Silences ember-data's `DEPRECATE_STORE_EXTENDS_EMBER_OBJECT` deprecation
in the test-app via `ember-cli-build.js` so it is no longer thrown by
`throwOnUnhandled: true`. This is the fix the deprecation message itself
recommends and unblocks the 5 failing `Acceptance | hero` tests.
2. Removes `import Ember from 'ember'` (deprecated in RFC #1003) from the
addon by importing the specific symbols directly:
- `Ember.testing` → `macroCondition(isTesting())` from `@embroider/macros`
- `Ember._setClassicDecorator` → `setClassicDecorator` from
`@ember/-internals/metal`
- `Ember.ViewUtils.getViewBounds` → `getViewBounds` from
`@ember/-internals/views`
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Replace deprecated `import { inject as service }` with `import { service }`
in the four test-app files that still used it (DEPRECATE_IMPORT_INJECT,
added in ember-source 6.2 / enabled 6.3).
- Silence the residual `deprecate-import-*-from-ember` family in the
deprecation workflow. The remaining hits originate inside ember-data /
ember-cli-fastboot internals (visible in the FastBoot bundle's
initializer load), not the addon or test-app source — silenced via
`matchId` regex until those upstream packages migrate.
- Silence `importing-inject-from-ember-service` similarly: ember-modal-dialog
is pinned to 4.0.0 in pnpm overrides and still uses
`import { inject as service }`.
This unblocks the ember-release try-scenario locally; ember-beta/canary still
fail at ember-cli's `EmberApp._initVendorFiles` because ember-source 7 ships
as a v2 addon and no longer exposes `paths` to the classic builder. That's a
build-system migration that's out of scope for this PR.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
NullVoxPopuli
force-pushed
the
nvp/ember-7
branch
from
May 10, 2026 22:35
2e390cc to
292bf62
Compare
NullVoxPopuli
marked this pull request as ready for review
May 10, 2026 22:36
…ures in ember-cli-build
This reverts commit 6c5b783.
Add an unpolyfill, because ember-data did a breaking change in a minor
NullVoxPopuli
force-pushed
the
nvp/ember-7
branch
from
May 11, 2026 02:48
6ed7ac2 to
8c5a2ba
Compare
Contributor
Author
|
I think the docs app will need to be updated. options:
|
Contributor
|
The whole point of keeping a separate docs app is that it doesn't need to support the same range of ember versions that the library does. Making the library support ember 7 should not require getting the docs app on ember 7. |
Contributor
Author
|
I don't have time to pursue finishing this rn, so I'll close so as to not dissuade others from solving this problem |
SergeAstapov
pushed a commit
that referenced
this pull request
Jun 18, 2026
The library imported ViewUtils and _setClassicDecorator from the `ember` barrel and read `Ember.testing`, all deprecated and removed in ember-source 7.0.0. Import getViewBounds from @ember/-internals/views, setClassicDecorator from @ember/-internals/metal, and use @embroider/macros isTesting() instead. The test-app's own components, routes, and a test imported `inject` from @ember/service; switch them to the `service` named export. Library changes taken from NullVoxPopuli's nvp/ember-7 branch (PR #796), scoped to the deprecation fixes; the docs app and dependency/tooling changes from that branch are left out. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses
As an aside tho -- do the tests for this really need to use ember-data?