Fix barrel-import and inject deprecations#800
Merged
SergeAstapov merged 1 commit intoJun 18, 2026
Merged
Conversation
The library imported ViewUtils and _setClassicDecorator from the `ember` barrel and read `Ember.testing`, all deprecated and removed in ember-source 7.0.0. Import getViewBounds from @ember/-internals/views, setClassicDecorator from @ember/-internals/metal, and use @embroider/macros isTesting() instead. The test-app's own components, routes, and a test imported `inject` from @ember/service; switch them to the `service` named export. Library changes taken from NullVoxPopuli's nvp/ember-7 branch (PR ember-animation#796), scoped to the deprecation fixes; the docs app and dependency/tooling changes from that branch are left out. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
SergeAstapov
approved these changes
Jun 18, 2026
Collaborator
|
thank you @backspace ! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues #796 without touching the documentation.