Fix the 5 failing tests + remove import Ember from 'ember'#1
Merged
NullVoxPopuli merged 2 commits intoMay 8, 2026
Conversation
…m 'ember'`
Two changes:
1. Silences ember-data's `DEPRECATE_STORE_EXTENDS_EMBER_OBJECT` deprecation
in the test-app via `ember-cli-build.js` so it is no longer thrown by
`throwOnUnhandled: true`. This is the fix the deprecation message itself
recommends and unblocks the 5 failing `Acceptance | hero` tests.
2. Removes `import Ember from 'ember'` (deprecated in RFC #1003) from the
addon by importing the specific symbols directly:
- `Ember.testing` → `macroCondition(isTesting())` from `@embroider/macros`
- `Ember._setClassicDecorator` → `setClassicDecorator` from
`@ember/-internals/metal`
- `Ember.ViewUtils.getViewBounds` → `getViewBounds` from
`@ember/-internals/views`
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
|
- Replace deprecated `import { inject as service }` with `import { service }`
in the four test-app files that still used it (DEPRECATE_IMPORT_INJECT,
added in ember-source 6.2 / enabled 6.3).
- Silence the residual `deprecate-import-*-from-ember` family in the
deprecation workflow. The remaining hits originate inside ember-data /
ember-cli-fastboot internals (visible in the FastBoot bundle's
initializer load), not the addon or test-app source — silenced via
`matchId` regex until those upstream packages migrate.
- Silence `importing-inject-from-ember-service` similarly: ember-modal-dialog
is pinned to 4.0.0 in pnpm overrides and still uses
`import { inject as service }`.
This unblocks the ember-release try-scenario locally; ember-beta/canary still
fail at ember-cli's `EmberApp._initVendorFiles` because ember-source 7 ships
as a v2 addon and no longer exposes `paths` to the classic builder. That's a
build-system migration that's out of scope for this PR.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
NullVoxPopuli
merged commit May 8, 2026
2e390cc
into
NullVoxPopuli:nvp/ember-7
22 of 24 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing the work from ember-animation#796 (ember-animation/ember-animated). Two changes that get the test-library / floating-deps CI green and prepare the addon for Ember 7 / RFC #1003.
Summary
Unblock the 5
Acceptance | herofailures. WiththrowOnUnhandled: trueinapp.ts, ember-data'sember-data:deprecate-store-extends-ember-objectwas being thrown for every hero test. Followed the deprecation message's own recommendation and silenced it viaemberData.deprecations.DEPRECATE_STORE_EXTENDS_EMBER_OBJECT: falseintest-app/ember-cli-build.js. This actually opts the Store class out of EmberObject inheritance at build time rather than just suppressing the warning.Remove
import Ember from 'ember'from the addon (deprecated in RFC #1003, shipped in 6.5). Three usages, each replaced with a direct module import per the RFC's migration guide:Ember.testing(sprite.ts)macroCondition(isTesting())from@embroider/macrosEmber._setClassicDecorator(ember-scheduler.ts)setClassicDecoratorfrom@ember/-internals/metalEmber.ViewUtils.getViewBounds(ember-internals.ts)getViewBoundsfrom@ember/-internals/viewsWhat this does NOT do
ember-canary/ember-betatry-scenarios pass on its own. ember-source 7+ no longer exposespathsfor ember-cli's classic builder, soEmberApp._initVendorFilesblows up withCannot read properties of undefined (reading 'debug')before the tests even run. Fixing canary requires wiring the test-app to use embroider (@embroider/core+@embroider/webpack+@embroider/compat) for the canary/beta scenarios — happy to do that as a follow-up if you'd like, but it felt out-of-scope for this PR's "stop throwing deprecations" focus.throwOnUnhandled: true, workflow: []is preserved, and with these fixes nothing throws onember-source@~6.2.0.Test plan
pnpm --filter test-app test:ember→ 256 pass, 0 fail, 5 skip (was 5 fail before).pnpm lintclean in addon and test-app (eslint, prettier, glint, ember-template-lint, tsc, stylelint).pnpm --filter ember-animated buildsucceeds (rollup + glint declarations).Sprite is sealed in test modeunit test still passes with themacroCondition(isTesting())swap.🤖 Generated with Claude Code