DAOS-18304 ddb: Introduce DdbAPI interface and fix db_path propagation by knard38 · Pull Request #18124 · daos-stack/daos

knard38 · 2026-04-28T14:17:04Z

Description

This PR is the second split of #17967, broken out at reviewers' request to make the review process easier. The first split #18125, contains unrelated code fixes found during the creation of the initial PR #17967. The content of this PR cannot be reduced further without breaking the build, as the Go interface and the C dv_pool_open API changes are tightly coupled: the new method signatures in the Go layer directly depend on the updated C function signature, so neither half can land independently.

This patch refactors the ddb Go CLI layer and the underlying C VOS pool open API to improve testability and fix a db_path propagation bug.

Go layer

Introduces a DdbAPI interface in commands_wrapper.go capturing all ddb operations, decoupling command dispatch from the concrete DdbContext implementation.
Converts all standalone ddbXxx(ctx *DdbContext, ...) functions to methods on *DdbContext, making DdbContext implement DdbAPI.
Passes dbPath explicitly to Open, Feature, and RmPool instead of storing it globally in ctx.ctx.dc_db_path, preventing the value from leaking across commands.
Renames Go parameters to follow camelCase conventions.

C layer

Simplifies the dv_pool_open API: callers pass a *ddb_ctx directly instead of a pre-parsed vos_file_parts; the function populates ctx->dc_poh.
Stores the full VOS file path in vf_vos_file_path within vos_file_parts, enabling callers to retrieve it without re-parsing.
Adds a VOS_PATH_SIZE overflow test and improves assertion coverage in ddb_parse_tests.c.

Steps for the author:

Commit message follows the guidelines.
Appropriate Features or Test-tag pragmas were used.
Appropriate Functional Test Stages were run.
At least two positive code reviews including at least one code owner from each category referenced in the PR.
Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

Gatekeeper requested (daos-gatekeeper added as a reviewer).

…limits - Add vf_vos_file_path field to vos_file_parts to retain the original VOS file path through the parsing pipeline, so callers no longer need to keep the input pointer alive after parse_vos_file_parts() returns. - Rename the enum to introduce VOS_PATH_SIZE (alongside DB_PATH_SIZE) and raise both constants from 256 to PATH_MAX. - Validate the VOS path length in parse_vos_file_parts() and return -DER_EXCEEDS_PATH_LEN when the limit is exceeded. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

…hing from ddb_ctx Remove dc_pool_path and dc_db_path from ddb_ctx: callers now pass paths as explicit arguments instead of storing them in the context, eliminating the need for the SetCString() helper. dv_pool_open() and dv_pool_destroy() signatures are simplified from (path, path_parts, poh, flags, write_mode) to (path, db_path, ctx, flags): - vos_file_parts allocation is moved into the new internal helper create_vos_file_parts(), keeping the API surface minimal. - dc_write_mode and dc_poh are set directly on the ctx, so the caller gets the pool handle back without an extra out-parameter. ddb_run_open(), ddb_run_feature() and ddb_run_rm_pool() in ddb_commands.c are simplified accordingly. ddb_run_feature() also gains an explicit error message on dv_pool_open() failure. ddb_run_dtx_stat() no longer prints ctx->dc_pool_path (which no longer exists). Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

Update all dv_pool_open() and dv_pool_destroy() call sites to use the new (path, db_path, ctx) signature: path_parts is no longer allocated by callers, and the pool handle is read back from ctx->dc_poh. ddb_parse_tests.c: add vf_vos_file_path assertions in success cases; add a test for VOS paths exceeding VOS_PATH_SIZE; add a dedicated MD-on-SSD test for DB_PATH_SIZE independently of VOS_PATH_SIZE; introduce the MOCKED_VOS_PATH_STR macro to avoid repeated string literals. ddb_commands_tests.c: move dvt_vos_insert_2_records_with_dtx() into dcv_suit_setup() so dtx records are present for all tests in the suite; correct VOS tree path indices for ls, value_dump and ilog_dump tests; update the dtx_stat expected message. ddb_vos_tests.c: update open_pool_test(), pool_flags_tests(), dv_test_setup() and helper_stat_open_modify_close_stat() for the new API. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

…methods Add the DdbAPI interface that lists every ddb sub-command as a method. It decouples the command layer from the concrete CGo implementation so tests can inject a stub without a live VOS environment. Convert all ddbXxx() free functions to (ctx *DdbContext) Xxx() methods, matching the DdbAPI interface. InitDdb() becomes (ctx *DdbContext) Init() so the caller (or a stub) controls object allocation. Open(), Feature() and RmPool() now receive db_path as an explicit argument instead of reading it from ctx.ctx.dc_db_path (which was removed from the C struct in the previous commit). Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

ddb_commands.go: addAppCommands() now takes a DdbAPI instead of a *DdbContext; every command Run closure calls api.Xxx() instead of the former ddbXxx(ctx, ...) free functions. The 'open' and 'feature' commands pass db_path explicitly; 'rm_pool' now requires --vos_path. main.go: - parseOpts() no longer calls os.Exit(); it returns (cliOptions, *flags.Parser, error) so the function is fully unit-testable. - A new run() function owns the DDB context lifetime: Init/defer-cleanup, auto-open logic, non-interactive command dispatch, interactive loop. - --version is handled in main() before run(), printing directly instead of synthesising a fake command. - --db_path without --vos_path returns an explicit error. - The HasPrefix loop for auto-open exclusions is replaced by a noAutoOpen map for exact command-name matching. - Pool close is consolidated into a closePoolIfOpen() helper used with defer. - Errors from runCmdStr() and runFileCmds() are now propagated. - unknownCmdError typed struct enables type-safe detection; exitWithError() prints the command list on unknown commands and fixes the duplicated ERROR: prefix in fault resolution messages. - errHelpRequested sentinel avoids os.Exit() in the --help path. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

Fix reviewers comments: - Use MOCKED_VOS_PATH_STR instead of the hardcoded "/" MOCKED_POOL_UUID_STR "/vos-0" string literal. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

Fixed reviewers comments: - Use slice instead of dictionary Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

github-actions · 2026-04-28T15:32:35Z

Ticket title is 'Add unit test to ddb go code'
Status is 'In Review'
https://daosio.atlassian.net/browse/DAOS-18304

daosbuild3 · 2026-04-29T21:28:49Z

Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18124/2/execution/node/1184/log

janekmi

A few minor issues. I am very happy with this change otherwise. 👍

janekmi · 2026-05-01T16:50:58Z


-	/* Test invalid vos paths with too long db path */
+	/* Test invalid vos paths with too long vos path */
+	D_ALLOC_ARRAY_CHECK(buf, VOS_PATH_SIZE + 1);


Nitpick. But you do not have to allocate, free and re-allocate again. You can make it big enough to handle all cases and just populate it with what is necessary.

The reason I allocate, free, and re-allocate is to ensure the buffer is always freed even when an assertion fails. From what I know, cmocka's assert_* macros use longjmp under the hood, so a failing assert exits the test immediately, bypassing any cleanup that follows.
By freeing buf before calling assert_rc_equal, I guarantee no leak regardless of the test outcome.

There is no leak when the process is terminated. AFAIK OS reclaims all of the process' memory on termination. So, you do not have to worry about it.

You may argue it is a bad practice. But IMHO the happy day scenario is even worse since each of the successful rounds do a lot more than is necessary just for the sake of testing what you want to test.

Please reconsider.

You are right that the OS reclaims the process memory on exit.
My concern is that valgrind memcheck, which is integrated in the CI, will still report unfreed heap allocations at process exit — and the same issue would arise if DAOS is compiled with libasan.
The current free-before-assert pattern is the simplest way that I find to ensure clean output from these tools. The only acceptable alternative I can think of would be to replace assert_rc_equal with an if + goto to an error label where the free happens before asserting — but that feels like more complexity than the problem warrants for a test helper.
From my side, stack-allocating a ~4 KB buffer is not an acceptable solution.
Does that makes sense?

Update help text and descriptions to use "VOS" instead of "vos" for consistency. Also clarify "vos db" references to use "sys db" where appropriate. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

Fix reviewers comments. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

…/daos-18304-patch-001-split

janekmi · 2026-05-05T15:41:49Z

 		Name:      "close",
 		Aliases:   nil,
-		Help:      "Close the currently opened vos pool shard",
+		Help:      "Close the currently opened VOS pool shard",


You may chose to ignore this one. Since it is getting further and further from your core change.

We are opening a file but closing a shard? 🤔

Suggested change

Help: "Close the currently opened VOS pool shard",

Help: "Close the currently opened VOS pool file",

Fix help shard-> file

Fixed with commit de22289

janekmi · 2026-05-05T15:43:26Z

 		Name:      "rm_pool",
 		Aliases:   nil,
-		Help:      "Remove a vos pool.",
+		Help:      "Remove a VOS pool.",


A little bit similar here. We are removing a pool but the argument is a file. Confusing.

Fix help pool-> file

Fixed with commit de22289

kjacque

Only reviewed the Go side. LGTM. Comments are minor.

Nasf-Fan

Looks fine for me. Please resolve the merge conflict and re-commit. Thanks!

Nasf-Fan · 2026-05-07T07:16:31Z


+	assert_success(vos_cont_open(ctx.dc_poh, g_uuids[0], &coh));
+
+	dvt_vos_insert_2_records_with_dtx(coh);


What is the purpose of inserting two records after opening the container during the setup?

Originally (on master), dvt_vos_insert_2_records_with_dtx was called inside
dump_dtx_cmd_tests itself, since it was the only test that needed DTX records.
This PR adds four new DTX tests (dtx_stat_tests, dtx_commit_entry_tests,
dtx_act_discard_invalid_tests, dtx_abort_entry_tests) that all require those
records to be present. Rather than having dump_dtx_cmd_tests silently act as
setup for the tests that follow it — which would be fragile and order-dependent —
the insertion was moved to dcv_suit_setup so it is part of the explicit, declared
fixture for the entire suite.

I will add a comment to make this intent clear:

Add comment on dvt_vos_insert_2_records_with_dtx(coh)

Fixed with commit bdd01e8

…/daos-18304-patch-001-split

mjmac · 2026-05-07T17:44:32Z

+// DdbAPI defines the set of ddb operations exposed to the command layer.
+// It abstracts the concrete DdbContext implementation to enable dependency
+// injection and unit testing via mock implementations.
+type DdbAPI interface {


Hmm. I understand the intent behind this interface, but giant predefined "god" interfaces is a well-known anti-pattern in Go. Per the community review guidelines, interfaces should be defined at the consumer site. This guidance is codified in the "Accept interfaces, return structs" proverb. While superficially the predefined interface may seem like the easier or more convenient path, it's a trap. It means that every implementation has to define all of those methods, leading to maintenance headaches and friction that results in good tests not being written.

At a minimum, just rearchitecting the tests to define interfaces for the subset of DdbContext methods that will be tested should make this much less of a tech debt trap.

For an alternative approach to doing Go/cgo testing, take a look at src/control/lib/daos/api. It's not perfect, but I think it achieves the goal of exposing as much of the Go surface for unit testing as possible. It also demonstrates a better design (IMO) than a single API object thing that has (at current count) 28 methods. I suggest a smaller, focused fix for the db_path problem and a follow up effort to rework this package along similar lines to the libdaos Go API. It's more work in the short term, but will yield long-term benefits.

Agreed. I think the argument for going this PR's route is entirely as an intermediate step to increase testability in the short term. It is indeed technical debt that will need a thoughtful redesign in the future either way.

@mjmac thank you for pointing this out with a concrete alternative to follow.
My apologies to @tanabarr and @kjacque who had already pinpointed this issue — I had not fully
internalized how much the god-interface pattern goes against Go best practices. I have to admit
that at the time I did not see how to solve it without the god-interface pattern: still a Go
padawan, am I 😉

Following @mjmac's suggestion, I preferred fixing it now rather than carrying it as technical debt,
as in my experience it rarely gets easier to address later. I reworked the code to adopt the
build-tag CGo stub pattern used in src/control/lib/daos/api. Commit 7310312 replaces the
DdbAPI god interface with that approach, and PR #18086 shows the stubs being exercised in unit
tests.

mjmac · 2026-05-07T18:13:42Z

 int
-dv_pool_open(const char *path, struct vos_file_parts *path_parts, daos_handle_t *poh,
-	     uint32_t flags, bool write_mode)
+dv_pool_open(const char *path, const char *db_path, struct ddb_ctx *ctx, uint32_t flags)


One potential problem with these changes is that it reduces composability by tying the code to the ddb CLI implementation. If there is any desire to repackage the shim later for improved maintainability and testability, this is a change that would need to be undone.

Thanks for pointing out this issue. Commit 9de3531 addresses it as you suggested.

While refactoring the god-interface pattern, I also identified a related coupling issue on the Go side: the CGo wrapper (commands_wrapper.go) was carrying CLI-specific logic — namely DtxAggr
argument validation and a log proxy field — that had no place in a translation layer between Go
and C.
The commit d683277 fixes this by moving the validation into the command layer and removing the log field from DdbContext.

Replace the opaque struct ddb_ctx * parameter with explicit poh and write_mode parameters so that dv_pool_open is a self-contained VOS helper. The coupling was identified by mjmac during code review of PR #18124. Move the vmd_wa_can_proceed() guard to the two callers (ddb_run_open and ddb_run_feature) using the existing DDB_CAN_PROCEED macro, which is already used at every other call site where a db_path is needed. No behaviour change: callers set ctx->dc_write_mode before calling dv_pool_open, and now also pass it explicitly. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

Address the god-interface anti-pattern identified by mjmac in PR #18124. Instead of a DdbAPI interface satisfied by a heavyweight DdbContextStub, use the build-tag pattern established in src/control/lib/daos/api: carries the -lddb / -lgurt LDFLAGS so that test builds do not require the ddb shared library. - libddb_stubs.go (test_stubs): per-function RC variables and Go-typed hook functions (ddb_run_ls_Fn, ddb_run_open_Fn, …) that tests set directly — no interface boilerplate needed. - commands_wrapper.go: drop DdbAPI interface and #cgo LDFLAGS; all C.ddb_xxx() calls are replaced by the Go wrapper calls defined in the two files above. - ddb_commands.go / main.go: replace DdbAPI with *DdbContext throughout. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

The mutual-exclusion check between --cmt_time and --cmt_date belongs in the command layer (ddb_commands.go) rather than in the CGo wrapper. Moving it there removes the only caller of ctx.log, which in turn allows two further simplifications: - Remove the log field from DdbContext (it was only a proxy for passing error messages up from the wrapper layer). - Simplify Init() to Init() (func(), error) — the logger argument is no longer needed at context-initialisation time. The validation now returns a plain fmt.Errorf, consistent with how other command-layer argument errors (e.g. flag parsing) are reported. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

unknownCmdError.Error() previously emitted a different string than grumbleUnknownCmdErr. Tests using errUnknownCmd (defined as ddbTestErr(grumbleUnknownCmdErr)) failed for the command-line code path because the error text did not contain grumbleUnknownCmdErr. Reuse grumbleUnknownCmdErr as the prefix so that assertions work consistently for both the command-line and command-file execution paths. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

Apply gofmt alignment to function declarations in libddb.go and libddb_stubs.go to keep the files consistently formatted. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

Replace the single-line comment with a full Doxygen block. Fix db_path description (NULL/empty derives the DB dir from path), correct the flags example from VOS_POF_RDB to VOS_POF_FOR_FEATURE_FLAG, and document the copy-on-write mechanism used by write_mode=false. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

…/daos-18304-patch-001-split

Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

@return

Replace \param[in]/\param[out]/\return tags with the @param/@return style used throughout the DAOS codebase (e.g. ddb.h, ddb_tree_path.h). Remove direction tags [in]/[out] as they are not used in DAOS Doxygen. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

Restore the original 'Unknown command: <cmd>. Run help to see available commands.' message in unknownCmdError.Error() instead of reusing grumble's internal error string. Also fix runFileCmds to detect the grumble unknown-command sentinel and wrap it as an unknownCmdError, so that both the command-line and command-file paths produce a consistent error message. The test sentinel in patch-002 is updated accordingly to match 'Unknown command:' rather than grumble's internal string. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

mjmac

LGTM, nice cleanup!

kjacque

LGTM.

knard38 · 2026-05-18T08:58:55Z

@daos-stack/daos-gatekeeper please could you lend this PR with the following message please:

title: DAOS-18304 ddb: Introduce DdbAPI interface and fix db_path propagation
body:

Refactor the ddb C API and Go CLI layer to improve testability and fix error handling:
- Replace the monolithic DdbAPI god interface with build-tag CGo stubs, enabling Go unit testing
  without a full DAOS installation.
- Simplify the dv_pool_open C API: callers now pass a *ddb_ctx  directly instead of pre-parsed
  vos_file_parts, reducing coupling between the VOS layer and command dispatch.
- Move DtxAggr flag validation from the C layer to the Go command layer.
- Restore the user-friendly "Unknown command" error message and fix runFileCmds to wrap
  unknown-command errors consistently.

Introduce the Go test suite for the ddb CLI layer, built on top of the build-tag CGo stub infrastructure landed in #18124: - Add test_helpers.go: newTestContext(t) resets all CGo stubs via resetDdbStubs() and returns a *DdbContext ready for use in tests. Test cases set per-function _Fn hook variables directly. - All test files carry the //go:build test_stubs tag so they only compile when the stub infrastructure is present. - TestCmds: open (default, write_mode, db_path), feature (show, enable, disable), and dtx_aggr (mutual exclusion, cmt_time, cmt_date, path). Adds skipCmdLine field for flags shared between CLI and grumble layers. - TestHelpCmds: unknown-command help flow. - TestParseOpts / TestRun: CLI-level option parsing and run() dispatch, including unknown-command detection for both command-line and command-file paths. - TestNewLogger: 6 sub-cases (default level, explicit debug, invalid level, valid LogDir, non-existent LogDir, LogDir is a file). - TestClosePoolIfOpen: Close not called when already closed, called when open, Close error tolerated. Test-tag: unittest Required-githooks: yes Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

kanard38 added 6 commits April 28, 2026 13:41

DAOS-18304 ddb: use MOCKED_VOS_PATH_STR macro in Go unit tests

7b3c6ac

Fix reviewers comments: - Use MOCKED_VOS_PATH_STR instead of the hardcoded "/" MOCKED_POOL_UUID_STR "/vos-0" string literal. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

knard38 changed the title ~~DAOS-18304 ddb: TODO~~ DAOS-18304 ddb: Introduce DdbAPI interface and fix db_path propagation Apr 28, 2026

knard38 mentioned this pull request Apr 28, 2026

DAOS-18304 ddb: Fix memory leaks, defer ordering, and pool handle corruption #18125

Merged

6 tasks

DAOS-18304 ddb: replace noAutoOpen map with a string slice

b0f7207

Fixed reviewers comments: - Use slice instead of dictionary Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

knard38 self-assigned this Apr 28, 2026

knard38 mentioned this pull request Apr 28, 2026

DAOS-18304 ddb: Introduce DdbAPI interface for Go unit testing #17967

Closed

6 tasks

knard38 marked this pull request as ready for review April 28, 2026 15:37

knard38 requested review from a team as code owners April 28, 2026 15:37

knard38 requested review from Nasf-Fan, janekmi, kjacque, mjmac and tanabarr April 28, 2026 15:38

janekmi requested changes May 1, 2026

View reviewed changes

kanard38 added 2 commits May 4, 2026 09:19

daos-18304 ddb: capitalize VOS in help strings

425fc48

Update help text and descriptions to use "VOS" instead of "vos" for consistency. Also clarify "vos db" references to use "sys db" where appropriate. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

daos-18304 ddb: improve unknown command error message

beaeed7

Fix reviewers comments. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

knard38 requested a review from janekmi May 4, 2026 09:35

Merge remote-tracking branch 'origin/master' into ckochhof/fix/master…

c12dcbb

…/daos-18304-patch-001-split

janekmi previously approved these changes May 5, 2026

View reviewed changes

kjacque previously approved these changes May 7, 2026

View reviewed changes

Comment thread src/control/cmd/ddb/commands_wrapper.go Outdated

Comment thread src/control/cmd/ddb/commands_wrapper.go

Nasf-Fan reviewed May 7, 2026

View reviewed changes

Merge remote-tracking branch 'origin/master' into ckochhof/fix/master…

b622710

…/daos-18304-patch-001-split

knard38 dismissed stale reviews from kjacque and janekmi via 56e0956 May 7, 2026 09:51

knard38 requested review from Nasf-Fan, janekmi and kjacque May 7, 2026 09:54

mjmac reviewed May 7, 2026

View reviewed changes

kanard38 added 8 commits May 11, 2026 08:16

DAOS-18304 ddb: fix gofmt alignment in libddb Go wrappers

0e95e3a

Apply gofmt alignment to function declarations in libddb.go and libddb_stubs.go to keep the files consistently formatted. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

Merge remote-tracking branch 'origin/master' into ckochhof/fix/master…

d3e88ed

…/daos-18304-patch-001-split

DAOS-18304 ddb: fix clang-format line length in ddb_vos_tests

a6cfa13

Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>

knard38 requested a review from mjmac May 11, 2026 13:32

knard38 mentioned this pull request May 11, 2026

DAOS-18304 ddb: add C unit tests for ddb_run_open #18214

Open

6 tasks

tanabarr approved these changes May 12, 2026

View reviewed changes

mjmac approved these changes May 14, 2026

View reviewed changes

kjacque approved these changes May 14, 2026

View reviewed changes

knard38 requested a review from a team May 18, 2026 08:43

daltonbohning merged commit 86f31a2 into master May 18, 2026
46 checks passed

daltonbohning deleted the ckochhof/fix/master/daos-18304-patch-001-split branch May 18, 2026 14:43

knard38 mentioned this pull request May 19, 2026

DAOS-18304 ddb: Add Go unit tests for ddb command layer #18086

Open

6 tasks

	Help: "Close the currently opened VOS pool shard",
	Help: "Close the currently opened VOS pool file",


		assert_success(vos_cont_open(ctx.dc_poh, g_uuids[0], &coh));

		dvt_vos_insert_2_records_with_dtx(coh);

Conversation

knard38 commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Go layer

C layer

Steps for the author:

After all prior steps are complete:

Uh oh!

github-actions Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daosbuild3 commented Apr 29, 2026

Uh oh!

janekmi left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knard38 May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knard38 May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knard38 May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kjacque left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Nasf-Fan left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knard38 May 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knard38 May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

knard38 May 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mjmac left a comment

Choose a reason for hiding this comment

Uh oh!

kjacque left a comment

knard38 commented Apr 28, 2026 •

edited

Loading

github-actions Bot commented Apr 28, 2026 •

edited

Loading

knard38 May 7, 2026 •

edited

Loading

knard38 May 7, 2026 •

edited

Loading

knard38 May 7, 2026 •

edited

Loading

knard38 May 7, 2026 •

edited

Loading

knard38 May 11, 2026 •

edited

Loading

knard38 May 11, 2026 •

edited

Loading