DAOS-18304 ddb: Add Go unit tests for ddb command layer#18086
Open
knard38 wants to merge 1 commit into
Open
Conversation
6 tasks
knard38
force-pushed
the
ckochhof/fix/master/daos-18304-patch-002
branch
2 times, most recently
from
628036b to
c58c604
Compare
knard38
force-pushed
the
ckochhof/fix/master/daos-18304-patch-001
branch
from
3c4faba to
24d96e6
Compare
|
Ticket title is 'Add unit test to ddb go code' |
knard38
force-pushed
the
ckochhof/fix/master/daos-18304-patch-001
branch
from
24d96e6 to
f81f3be
Compare
knard38
force-pushed
the
ckochhof/fix/master/daos-18304-patch-002
branch
3 times, most recently
from
62c66ea to
6e01e12
Compare
knard38
force-pushed
the
ckochhof/fix/master/daos-18304-patch-002
branch
from
6e01e12 to
cda7452
Compare
Collaborator
|
Test stage Unit Test completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18086/11/testReport/ |
knard38
force-pushed
the
ckochhof/fix/master/daos-18304-patch-002
branch
from
47f06b5 to
a511b14
Compare
Collaborator
|
Test stage Unit Test completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18086/12/testReport/ |
knard38
force-pushed
the
ckochhof/fix/master/daos-18304-patch-002
branch
from
a511b14 to
03189b1
Compare
knard38
changed the base branch from
ckochhof/fix/master/daos-18304-patch-001
to
ckochhof/fix/master/daos-18304-patch-001-split
6 tasks
Collaborator
|
Test stage Unit Test completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18086/14/testReport/ |
knard38
force-pushed
the
ckochhof/fix/master/daos-18304-patch-002
branch
2 times, most recently
from
c3dd676 to
bd9f1f2
Compare
Collaborator
|
Test stage Functional Hardware Medium MD on SSD completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-18086/17/execution/node/717/log |
Base automatically changed from
ckochhof/fix/master/daos-18304-patch-001-split
to
master
May 18, 2026 14:43
knard38
force-pushed
the
ckochhof/fix/master/daos-18304-patch-002
branch
3 times, most recently
from
f6a67bd to
8b2e76b
Compare
Introduce the Go test suite for the ddb CLI layer, built on top of the build-tag CGo stub infrastructure landed in #18124: - Add test_helpers.go: newTestContext(t) resets all CGo stubs via resetDdbStubs() and returns a *DdbContext ready for use in tests. Test cases set per-function _Fn hook variables directly. - All test files carry the //go:build test_stubs tag so they only compile when the stub infrastructure is present. - TestCmds: open (default, write_mode, db_path), feature (show, enable, disable), and dtx_aggr (mutual exclusion, cmt_time, cmt_date, path). Adds skipCmdLine field for flags shared between CLI and grumble layers. - TestHelpCmds: unknown-command help flow. - TestParseOpts / TestRun: CLI-level option parsing and run() dispatch, including unknown-command detection for both command-line and command-file paths. - TestNewLogger: 6 sub-cases (default level, explicit debug, invalid level, valid LogDir, non-existent LogDir, LogDir is a file). - TestClosePoolIfOpen: Close not called when already closed, called when open, Close error tolerated. Test-tag: unittest Required-githooks: yes Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
knard38
force-pushed
the
ckochhof/fix/master/daos-18304-patch-002
branch
from
8b2e76b to
658f2f3
Compare
Collaborator
|
Test stage NLT completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-18086/22/testReport/ |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Overview
Go unit tests for the
ddbCLI command layer, building on the build-tag CGo stub infrastructureintroduced in the predecessor PR #18124.
Tests are gated behind the
test_stubsbuild tag and run without a live VOS environment. The CGofunction stubs provided by
libddb_stubs.goexpose configurable return-code variables(
ddb_init_RC,ddb_pool_is_open_RC, …) and hook variables (ddb_init_Fn, …) that let testscontrol stub behaviour without modifying production code.
New Files
test_helpers.goTest infrastructure shared across all test files:
newTestContext: allocates aDdbContextbacked by the CGo stubs.captureStdout: redirectsos.Stdoutto a pipe for the duration of a function call andreturns the captured output as a string.
runCmdToStdout: callsparseOpts()with given args and captures stdout.runMainFlow: simulates the fullmain()flow (parse → version check → run) withoutcalling
os.Exit().assertContainsAll: asserts that a string contains every element of a given slice — used byTestManPageto avoid repetitive loops.isArgEqual: type-safe argument comparison helper.ddb_commands_test.goTests for the grumble command definitions:
TestHelpCmds: verifies--helpoutput for thelsandopencommands.TestCmds: argument and option parsing forls(--recursive,--details),open(
--vos_path,--db_path,--write_mode),feature(--enable/--disable),dtx_aggr(mutual-exclusion validation),
close, andversion.TestManPage: verifies man page output both to stdout and to a file, using a sharedexpSectionslist.main_test.goTests for the CLI entry-point logic:
TestParseOpts: default option values, flag parsing (--debug,--write,--vos_path,--db_path,--version,--cmd,--cmd_file) and error cases (conflicting--cmd/--cmd_file, missing--vos_pathwhen--db_pathis set).TestRun: version output, unknown command detection,noAutoOpenlist (feature, open,smd_sync), auto-open via
--vos_path/--db_path,ctx.Init()failure,ctx.Open()failure.TestRunMultiLineCommandFile: verifies that a command file with multiple commands executesall of them in order.
TestStrToLogLevels: all supported log-level string conversions.TestNewLogger: logger creation for each log level.TestClosePoolIfOpen: pool-not-open, successful close, and close-error paths.Steps for the author:
After all prior steps are complete: