DAOS-18304 ddb: add C unit tests for ddb_run_open#18214
Open
knard38 wants to merge 2 commits into
Open
Conversation
|
Ticket title is 'Add unit test to ddb go code' |
knard38
force-pushed
the
ckochhof/fix/master/daos-18304-patch-003
branch
from
2ebb05b to
aaa9e2b
Compare
Base automatically changed from
ckochhof/fix/master/daos-18304-patch-001-split
to
master
May 18, 2026 14:43
Add open_cmd_tests to ddb_commands_tests.c to cover the four main behaviors of ddb_run_open: - invalid path returns DER_INVAL - read-only (CoW) open sets dc_poh valid and dc_write_mode=false - write-mode open sets dc_poh valid and dc_write_mode=true - opening a pool that is already open returns DER_BUSY Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
knard38
force-pushed
the
ckochhof/fix/master/daos-18304-patch-003
branch
from
aaa9e2b to
357ba4d
Compare
Add ddb_commands_ut.c with unit tests using --wrap=vmd_wa_can_proceed to exercise the DDB_CAN_PROCEED error path that cannot be reached in integration tests (vmd_wa_can_proceed always returns true without nvme config): - open_can_proceed_failure: verifies ddb_run_open returns -DER_NO_SERVICE when vmd_wa_can_proceed returns false - version: verifies ddb_run_version prints the version string - close_not_open: verifies ddb_run_close returns 0 when no pool is open Register the new test suite in ddb_ut as suite 'b'. Signed-off-by: Cedric Koch-Hofer <cedric.koch-hofer@hpe.com>
knard38
force-pushed
the
ckochhof/fix/master/daos-18304-patch-003
branch
from
9998a74 to
142b909
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds C-level unit tests for
ddb_run_openand theDDB_CAN_PROCEEDerror path. It is a follow-up to #18124 and complements #18086 (Go unit tests).Integration tests (
ddb_commands_tests.c): coverddb_run_openwith a real VOS pool — invalid path (-DER_INVAL), read-only open, write-mode open, and already-open (-DER_BUSY).Unit tests (
ddb_commands_ut.c): use--wrap=vmd_wa_can_proceedinddb_utto exercise theDDB_CAN_PROCEEDmacro returning-DER_NO_SERVICE— a path unreachable in integration tests sincevmd_wa_can_proceed()always returnstruewithoutdaos_nvme.conf. Also testsddb_run_versionandddb_run_closein isolation.Steps for the author:
After all prior steps are complete: