added interface to macro _KNOMI_STATUS

[Surion79]

Due to the errors with G28 and homing override, I created this PR. This PR consists of two parts:

• Changes in source code (main.cpp)
• Functional documentation (described in this PR text)

I added a new part of looking through the API calls for a macro called _KNOMI_STATUS instead of G28 and BED_MESH_CALIBRATE.

It is NOT backwards compatible with the "original" version!
The new _KNOMI_STATUS macro would need to look like this

[gcode_macro _KNOMI_STATUS] 
variable_homing: False  
variable_probing: False  
gcode:  

with this it is now generally possible to set the status whereever it is needed.
Therefore just add the following lines where it is appropriate:

SET_GCODE_VARIABLE MACRO=_KNOMI_STATUS VARIABLE=homing VALUE=True
SET_GCODE_VARIABLE MACRO=_KNOMI_STATUS VARIABLE=homing VALUE=False

SET_GCODE_VARIABLE MACRO=_KNOMI_STATUS VARIABLE=probing VALUE=True
SET_GCODE_VARIABLE MACRO=_KNOMI_STATUS VARIABLE=probing VALUE=False

if you use a homing_override you can add it like this: (this is just a technical example!)

SET_GCODE_VARIABLE MACRO=_KNOMI_STATUS VARIABLE=homing VALUE=True
G28
SET_GCODE_VARIABLE MACRO=_KNOMI_STATUS VARIABLE=homing VALUE=False

This does not require a G28 override which is not possible when using homing_override.

My KNOMI display ships in a couple days, so i wasn't able to test this with a KNOMI display.

[Cyondil]

I have the Knomi and tested your PR and it doesn't seem to work at all for either homing or probing

First, the variables of true and false need to have the first letter capitalized (True/False) or else Klipper throws up an error.

For homing, still issues with it not updating the status on the Knomi even with the above fix. Seems like G28 is going to be tougher nut to crack.

For probing, this also does not seem to work. I use KAMP so I was able to get it to work by adding the variable under the KAMP cfg and adding the below lines to the beginning and end of the KAMP bed mesh macro. When I pointed them to the _KNOMI_STATUS it also did not reflect correctly.
SET_GCODE_VARIABLE MACRO=BED_MESH_CALIBRATE VARIABLE=probing VALUE=True
SET_GCODE_VARIABLE MACRO=BED_MESH_CALIBRATE VARIABLE=probing VALUE=False

Not much of someone who digs into code. but seems to me that there is something specifically looking for the combo of BED_MESH_CALIBRATE/G28 and the variable switch.

[Surion79]

I have the Knomi and tested your PR and it doesn't seem to work at all for either homing or probing

First, the variables of true and false need to have the first letter capitalized (True/False) or else Klipper throws up an error.

For homing, still issues with it not updating the status on the Knomi even with the above fix. Seems like G28 is going to be tougher nut to crack.

For probing, this also does not seem to work. I use KAMP so I was able to get it to work by adding the variable under the KAMP cfg and adding the below lines to the beginning and end of the KAMP bed mesh macro. When I pointed them to the _KNOMI_STATUS it also did not reflect correctly. SET_GCODE_VARIABLE MACRO=BED_MESH_CALIBRATE VARIABLE=probing VALUE=True SET_GCODE_VARIABLE MACRO=BED_MESH_CALIBRATE VARIABLE=probing VALUE=False

Not much of someone who digs into code. but seems to me that there is something specifically looking for the combo of BED_MESH_CALIBRATE/G28 and the variable switch.

Thanks, i updated the documentation.
Although i did not grasp your other issue. Can you give a full example of your code where you put it? You commented code, which is not part of my documentation

I just added 1 additional iteration to the original code. so the original documentation still is valid with all it stuff what works and what not.

[Cyondil]

Editing this comment because I missed the fact you made changes to the codebase itself. Just one of those days here and I realized now what changes you made. Retracting my previous comments as it looks as if you have everything already covered in your code changes. No further comments. Only thing that would be nice is if BTT would release a guide to update the firmware more easily!

[Surion79]

Editing this comment because I missed the fact you made changes to the codebase itself. Just one of those days here and I realized now what changes you made. Retracting my previous comments as it looks as if you have everything already covered in your code changes. No further comments. Only thing that would be nice is if BTT would release a guide to update the firmware more easily!

have you tried to update the firmware with this fix? does it work? my display takes some time until it arrives

[littleferris]

Thank you for this, it seems like the homing one works, but the probing does not. Just testing in the console.

[Surion79]

Thank you for this, it seems like the homing one works, but the probing does not. Just testing in the console.

Have you compiled the firmware and upgraded the knomi display with it?
Can you do it again? i updated it based on your feedback.

You can't set both value to true, otherwise, always the last check "wins".

btw: Old style is no longer working with last commit, as i replaced just the related sections with _KNOMI_STATUS

[Cyondil]

Editing this comment because I missed the fact you made changes to the codebase itself. Just one of those days here and I realized now what changes you made. Retracting my previous comments as it looks as if you have everything already covered in your code changes. No further comments. Only thing that would be nice is if BTT would release a guide to update the firmware more easily!

have you tried to update the firmware with this fix? does it work? my display takes some time until it arrives

Yeah that's the piece I was missing. I compiled the new firmware with the fix but haven't tried installing it yet. Got tied up with a few things and I'm hoping to get back to it within the next day or so and will report back! I need.to dig up if they have a method to install the firmware as I was running I to dead ends when I tried before, but didn't have a lot of time to spend with it.

[Cyondil]

I tested the code and it did not work. After digging through, I think I see the issue. You originally created a new httpswitch (5) that referenced the new _KNOMI_STATUS macro.

After this recent change where you removed the httpswitch = 5 and then changed the httpswitch =4 and httpswitch = 3 to focus on the _KNOMI_STATUS macro, it broke. It looks like now what happens, in lines 986 and 988, it's still looking for the G0028 and BED_MESH_CALIBRATE to trigger these switches. I edited the code to replace G0028 and BED_MESH_CALIBRATE with _KNOMI_STATUS and then compiled and uploaded the firmware. Both Homing and Probing now show correctly on the display.

Since httpswitch =5 is no longer required the lines 989 and 990 can now be removed as well.

Once I made these changes, compiled and uploaded the firmware, I'm no able to successfully see that Knomi changes for both homing AND probing! Now I just need to figure out how I can change the colors from red to blue. :)

Screenshot attached for reference.

[Surion79]

@Cyondil Thanks! Unfortunately i have not my KNOMI yet, so I couldn't test the changes.
I updated the file accordingly and commited it, so it should be now working. As replacement

[Surion79]

i removed http switch 5, so it should not be added and kept as in original. other stuff i changed accordingly. should work now like this

[Cyondil]

Changes look good and have been tested as working with the new macro. No recursive issues with homing.

[miweimann]

hello, i want to test this also. Please can you tell me how to compile and how to load this firmware onto my Knomi. i have tried with ESP-Flasher, but no success. Maybe also the compiled firmware isn´t ok. So i need your help please.

[Cyondil]

hello, i want to test this also. Please can you tell me how to compile and how to load this firmware onto my Knomi. i have tried with ESP-Flasher, but no success. Maybe also the compiled firmware isn´t ok. So I need your help please.

Easiest is to use VSCode with the Platform.io extension. With the Knomi connected to your computer in boot mode (hold the boot button while plugging it in and release once powered on), you build and then upload using the Platform.io extension.

[miweimann]

thanks, it worked now. good job

[Paliomalakas]

which files sould we upload?

[SrgntBallistic]

BTT has instructions on how to compile here:
https://bigtreetech.github.io/docs/KNOMI.html#customize-ui

[Paliomalakas]

Thank you very much Sent from Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: Brian Rowe ***@***.***> Sent: Monday, May 29, 2023 7:08:37 AM To: bigtreetech/KNOMI ***@***.***> Cc: Paliomalakas ***@***.***>; Comment ***@***.***> Subject: Re: [bigtreetech/KNOMI] added interface to macro _KNOMI_STATUS (PR #5) BTT has instructions on how to compile here: https://bigtreetech.github.io/docs/KNOMI.html#customize-ui — Reply to this email directly, view it on GitHub<#5 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AXUH5BFP2FAZWXOK4OT5LZTXIQOMLANCNFSM6AAAAAAYDUA2UI>. You are receiving this because you commented.Message ID: ***@***.***>

[SrgntBallistic]

I was able to get this working.

I am currently using the G28 override as I don't have a homing_override.

[appleimperio]

This works great. Thank you!

[acosano]

Hi. I run into the same problem. I have a G28 and Homing override and would like to implement your solution. How to get your branch as I can'tfigure it out. Thanks in advance

[appleimperio]

@acosano At the top of this page click on from Surion79:Knomi_Status_Macro. that will take you to the branch

[acosano]

So easy. Thanks for that. I will try it this morning. I'm not able to get this to compile. Is there a compiled version that Ijust can upload to the screen?

[3DMat]

solved by changing the source code because the package you download still uses the old configuration even if you update the knomi with vscode MASTER FILE NOT UPDATED WITH THE VERSION YOU WRITE

[ah-banny]

@Surion79 and @Cyondil

thank you very much for your work.
It worked very well on my Voron2.4. now the [quad_gantry_level] doesn't work yet.
But hopefully I can still do that ;)

[Ybalrid]

Hey, I like this idea!

Something like this may solve the configuration I and another user are experiencing with KAMP and BED_MESH_CALIBRATE (see issue #25 )

[BoothyBoothy]

Hi Surion79, many thanks for all your hard work on this. I have not tried this on any of my V2s because they now have tap. It does work a treat on my recent Minion upgrade with a Klicky Probe attached. However, for some reason the Knomi finish print macro (usually a green tick icon) does not seem to present itself when the print finishes? Any thoughts?

Thanks again for all your efforts. Best wishes Boothy

[TheSin-]

Why isn't the accepted yet? This is a much cleaner way over all!

[bigtreetech]

Thank you very much for your PR.
Inspired by this PR, the latest version of firmware has been implemented using this method.
https://github.com/bigtreetech/KNOMI/tree/firmware
https://github.com/bigtreetech/KNOMI/blob/master/KNOMI.cfg