Macros on PDF do not format Correctly and getting `Macro G28 called recursively` homing errors from provided macros

[BoothyBoothy]

Hi BTT

1. Copying the PDF macro content directly from the PDF does not work because all formatting content is lost and Klipper fails to boot due to parsing errors. The gcode lines need indenting to stop the parsing issue.
2. After including the Knomi Macros Print_Start fails with a repeated homing error stating Macro G28 called recursively (3 times).

Please advise and thanks Boothy

[hdragoon]

You may did something wrong, as I did the same as instruction and no problem at all.

[BoothyBoothy]

Thanks for the response. Hmmm, are you using a Klicky Probe or Tap? May be the external Klicky variable causing the issues? I doubt if my install will last long anyway, the PCF is less for it, great fun but not at the cost of print quality IMHO.

[BoothyBoothy]

Further to my last comment. I use a Klicky Probe on my V2. If I exclude the Klicky Variables.cfg the BTT homing macro works without errors and I get a House symbol on the Knomi display whilst homing, not tried anything else yet. The BTT macro therefore seems to work but does not allow for any external homing Macro reference like Klicky external Macros. I will need to consider what is the most tidy way forward with this and the Klicky. Thanks Boothy

[LSkyw4lker]

Same here. Also with Klicky Probe. Will figure out later today, how to fix it.

Bed Mesh works with this macro now:

Still no solution for Homing G28 without being recursively called.

Solved it now. Changed the source code to request a created macro variable "homing" in "_Probe_variables" instead of G28. Set it True at the beginning of "homing_override" and False at the end of macro "Park_Toolhead".

[Surion79]

@BoothyBoothy I created a Pull Request to fix the G28 issue by using a dedicated _KNOMI_STATUS macro

[Cyondil]

Added comments on the PR so updating this to reflect that.

[Bazeone]

The changes worked for me.

[sgermain06]

Yeah, I took a similar approach and added a CUSTOM_HOMING macro that the code is listening for, but it doesn't feel right. There has to be a better way to do this.

The main issue is related to any Klipper configuration that uses homing_override. This will call the G28 macro within its code, just like what klicky does.

[PeterGarthAmos]

Hi, all, I'm not that clued up with the code, please could you explain what you did exactly if you don't mind. (dumb it down) I have the same issue and have not been able to resolve it. I have klicky. the knomi macro causes Macro G28 called recursively.

[Fisheye3D]

I ran into this issue with beacon probe and also noticed it broke independent homing for X/Y and would home all axis effectively breaking other macros. Fix for me below.

[gcode_macro G28]
description: G28 homing with SB LED status
rename_existing: G0028
variable_homing:False

gcode:
SET_GCODE_VARIABLE MACRO=G28 VARIABLE=homing VALUE=True
status_homing
RESPOND MSG="Homing"
{% set home_all = 'X' not in params and 'Y' not in params and 'Z' not in params %} ; check if all axes are being homed
{% if home_all or 'X' in params %} ; if homing all axes or just x
G0028 X ; home X axis
{% endif %}
{% if home_all or 'Y' in params %} ; if homing all axes or just y
G0028 Y ; home Y axis
{% endif %}
{% if home_all or 'Z' in params %} ; if homing all axes or just z
G0028 Z ; home Z axis
{% endif %}
status_ready
SET_GCODE_VARIABLE MACRO=G28 VARIABLE=homing VALUE=False

[3DMat]

Same here. Also with Klicky Probe. Will figure out later today, how to fix it.

Bed Mesh works with this macro now:

Still no solution for Homing G28 without being recursively called.

Solved it now. Changed the source code to request a created macro variable "homing" in "_Probe_variables" instead of G28. Set it True at the beginning of "homing_override" and False at the end of macro "Park_Toolhead".

hello sorry can you put a screen of the macro for homing_override use klicky over if it's possible I'm trying the thousand recommended methods including using the _knomi_status updating the knomi with vcore and the bed mesh doesn't even work (only works using the one posted here)
A thousand thanks

solved by changing the source code because the package you download still uses the old configuration even if you update the knomi with vscode MASTER FILE NOT UPDATED

[silentstorm21]

i'm having this issue now

[BoothyBoothy]

I found this to work well on my Minion Bed Slinger with Klicky.
#5
The only thing that does not appear to work is the print finished macro? I have no problems with anything else.
Best Boothy

[nephilim667]

Hello, i have integrated a knomi on my Creality K1. As i have issues to modify Knomi firmware, i have found solution to make it works with sandard firmware.
You can found details of macros modifications here :
D3vil-Design/K1-Hardware-Mods#4 (comment)