Repository navigation
Adds more granularities control to bevy_transform related to bevy dependencies - #26365
Open
CodingDaniel1 wants to merge 4 commits into
Open
CodingDaniel1 wants to merge 4 commits into
CodingDaniel1 wants to merge 4 commits into
Conversation
SkiFire13
reviewed
Oct 29, 2026
kfc35
added
A-Transform
kfc35
approved these changes
Nov 5, 2026
|
|
||
| use bevy_ecs::{prelude::*, query::QueryFilter}; | ||
|
|
||
| /// Set enum for the systems relating to transform propagation |
Contributor
There was a problem hiding this comment.
nit: I think I would prefer this to be a separate PR, but I'm not going to block on this since this move seems ok...
... Although I might suggest having a migration guide for the move eventually. It's not a big deal though / necessary right now -- the prelude also re-exports the system set, so I'm unsure how many projects would be broken by the move
| ## This exists because it allows opting out of all of this, leaving only a bare-bones transform struct, | ||
| ## which enables users to depend on that without needing the larger Bevy dependency tree. | ||
| bevy-support = ["alloc", "dep:bevy_app", "dep:bevy_ecs"] | ||
| bevy-support = ["alloc", "bevy_app", "bevy_ecs"] |
Contributor
There was a problem hiding this comment.
nit: since bevy_app implicitly enables bevy_ecs as well, you can remove the bevy_ecs / alloc part of this, although maybe that warrants adding a comment that this is just an alias for the bevy_app feature
Suggested change
| bevy-support = ["alloc", "bevy_app", "bevy_ecs"] | |
| bevy-support = ["bevy_app"] |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
bevy_transformallows external use without the large bevy dependency tree, but it does not allow to specify which bevy dependencies to include (bevy_ecs, bevy_app).bevy-supportfeature simply enables both of them, which can be annoying whenbevy_appisn't needed. It would be nice to have finer granularity overbevy-support.Solution
Use the corresponding feature flag to replace previous
bevy-support.Testing
There is no actual code changes, only guards changes, and
bevy-supportflag is still present with just finer granularity. So just check the CI to see if it's passing the tests or not.