-
-
Couldn't load subscription status.
- Fork 4.2k
Add a setting to ImageLoader that calls Image::reinterpret_stacked_2d_as_array
#21628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this change! A few things:
- I think we can make the enum clearer
- this is a neat change, but not splashy enough for a release note
- this needs a short migration guide for the new field on
ImageLoaderSettings
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes. |
|
This tries to do something similar. At least the motivation is the same #20799 |
|
I went ahead and applied the suggested changes, but I would be fine closing in favor of #20799 if you'd prefer that one. |
Objective
If you want to use a
TilemapChunk(or more generally use atexture2DArrayin a shader), you have to implement a mechanism that waits for your texture to load, then callsImage::reinterpret_stacked_2d_as_array.Solution
Have the loader do it instead.
Testing
Showcase