Skip to content

Atmosphere bindings cleanup #21625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 29, 2025
Merged

Atmosphere bindings cleanup #21625

merged 2 commits into from
Oct 29, 2025
+112 −152

Conversation

@ecoskey
Copy link
Contributor

@ecoskey ecoskey commented Oct 21, 2025

Depends on #20838

Objective

There's some redundant sampler bindings in the atmosphere code

Solution

Remove them

Testing

Ran the example

@ecoskey ecoskey added S-Blocked This cannot move forward until something else changes A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels Oct 21, 2025
@ecoskey ecoskey marked this pull request as draft October 21, 2025 21:39
@ecoskey ecoskey mentioned this pull request Oct 22, 2025
Merged
@ecoskey ecoskey force-pushed the cleanup/atmo_bindings branch from ee9437d to 77484d2 Compare October 22, 2025 23:43
@ecoskey ecoskey marked this pull request as ready for review October 22, 2025 23:43
@ecoskey ecoskey added S-Needs-Review Needs reviewer attention (from anyone!) to move forward and removed S-Blocked This cannot move forward until something else changes labels Oct 22, 2025
@github-actions
Copy link
Contributor

Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke!
You can review it at https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D?filter=PR-21625

If it's expected, please add the M-Deliberate-Rendering-Change label.

If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it.

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Oct 27, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Oct 29, 2025
Merged via the queue into bevyengine:main with commit 0fa0b0e Oct 29, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

+1 more reviewer

@mate-h mate-h mate-h approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ecoskey @alice-i-cecile @mate-h