Skip to content

Rename Event to ObserverEvent #20598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Rename Event to ObserverEvent #20598

wants to merge 23 commits into from
+268 −225

Conversation

Zeophlite
Copy link
Contributor

@Zeophlite Zeophlite commented Aug 16, 2025 •
edited
Loading

Objective

  • Continues Split observer events #20151
  • As events no longer share a common supertrait it's confusing to have Event only refer to observer events

Solution

  • Rename Event to ObserverEvent

Testing

  • CI
  • cargo run --example observers

tim-blackbird and others added 18 commits July 15, 2025 19:36
@alice-i-cecile alice-i-cecile added A-ECS Entities, components, systems, and events X-Controversial There is active debate or serious implications around merging this PR S-Needs-SME Decision or review from an SME is required labels Aug 16, 2025
@alice-i-cecile alice-i-cecile added this to the 0.17 milestone Aug 16, 2025
@Zeophlite Zeophlite force-pushed the event-2-observer-event branch from ea30925 to 05480e9 Compare August 16, 2025 02:32
@Zeophlite Zeophlite marked this pull request as ready for review August 16, 2025 04:21
@Zeophlite Zeophlite changed the title Event 2 observer event Rename Event to ObserverEvent Aug 17, 2025
@Zeophlite Zeophlite force-pushed the event-2-observer-event branch from 73f876a to 543e535 Compare August 21, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events S-Needs-SME Decision or review from an SME is required X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
3 participants
@Zeophlite @alice-i-cecile @tim-blackbird