Skip to content

Add PipelineCompilationOptions to descriptors #19808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+158 −110
Draft

Add PipelineCompilationOptions to descriptors #19808

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crates/bevy_anti_aliasing/src/contrast_adaptive_sharpening/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,12 +224,12 @@ impl SpecializedRenderPipeline for CasPipeline {
blend: None,
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
primitive: PrimitiveState::default(),
depth_stencil: None,
multisample: MultisampleState::default(),
push_constant_ranges: Vec::new(),
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_anti_aliasing/src/fxaa/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,12 +196,12 @@ impl SpecializedRenderPipeline for FxaaPipeline {
blend: None,
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
primitive: PrimitiveState::default(),
depth_stencil: None,
multisample: MultisampleState::default(),
push_constant_ranges: Vec::new(),
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down
9 changes: 6 additions & 3 deletions crates/bevy_anti_aliasing/src/smaa/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,6 +485,7 @@ impl SpecializedRenderPipeline for SmaaEdgeDetectionPipeline {
shader_defs: shader_defs.clone(),
entry_point: "edge_detection_vertex_main".into(),
buffers: vec![],
compilation_options: Default::default(),
},
fragment: Some(FragmentState {
shader: self.shader.clone(),
Expand All @@ -495,6 +496,7 @@ impl SpecializedRenderPipeline for SmaaEdgeDetectionPipeline {
blend: None,
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
push_constant_ranges: vec![],
primitive: PrimitiveState::default(),
Expand All @@ -511,7 +513,6 @@ impl SpecializedRenderPipeline for SmaaEdgeDetectionPipeline {
bias: default(),
}),
multisample: MultisampleState::default(),
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down Expand Up @@ -545,6 +546,7 @@ impl SpecializedRenderPipeline for SmaaBlendingWeightCalculationPipeline {
shader_defs: shader_defs.clone(),
entry_point: "blending_weight_calculation_vertex_main".into(),
buffers: vec![],
compilation_options: Default::default(),
},
fragment: Some(FragmentState {
shader: self.shader.clone(),
Expand All @@ -555,6 +557,7 @@ impl SpecializedRenderPipeline for SmaaBlendingWeightCalculationPipeline {
blend: None,
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
push_constant_ranges: vec![],
primitive: PrimitiveState::default(),
Expand All @@ -571,7 +574,6 @@ impl SpecializedRenderPipeline for SmaaBlendingWeightCalculationPipeline {
bias: default(),
}),
multisample: MultisampleState::default(),
zero_initialize_workgroup_memory: false,
}
}
}
Expand All @@ -593,6 +595,7 @@ impl SpecializedRenderPipeline for SmaaNeighborhoodBlendingPipeline {
shader_defs: shader_defs.clone(),
entry_point: "neighborhood_blending_vertex_main".into(),
buffers: vec![],
compilation_options: Default::default(),
},
fragment: Some(FragmentState {
shader: self.shader.clone(),
Expand All @@ -603,12 +606,12 @@ impl SpecializedRenderPipeline for SmaaNeighborhoodBlendingPipeline {
blend: None,
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
push_constant_ranges: vec![],
primitive: PrimitiveState::default(),
depth_stencil: None,
multisample: MultisampleState::default(),
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_anti_aliasing/src/taa/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,12 +333,12 @@ impl SpecializedRenderPipeline for TaaPipeline {
write_mask: ColorWrites::ALL,
}),
],
compilation_options: Default::default(),
}),
primitive: PrimitiveState::default(),
depth_stencil: None,
multisample: MultisampleState::default(),
push_constant_ranges: Vec::new(),
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_core_pipeline/src/auto_exposure/pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ impl SpecializedComputePipeline for AutoExposurePipeline {
AutoExposurePass::Average => "compute_average".into(),
},
push_constant_ranges: vec![],
zero_initialize_workgroup_memory: false,
compilation_options: Default::default(),
}
}
}
2 changes: 1 addition & 1 deletion crates/bevy_core_pipeline/src/blit/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ impl SpecializedRenderPipeline for BlitPipeline {
blend: key.blend_state,
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
primitive: PrimitiveState::default(),
depth_stencil: None,
Expand All @@ -100,7 +101,6 @@ impl SpecializedRenderPipeline for BlitPipeline {
..Default::default()
},
push_constant_ranges: Vec::new(),
zero_initialize_workgroup_memory: false,
}
}
}
2 changes: 1 addition & 1 deletion crates/bevy_core_pipeline/src/bloom/downsampling_pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,12 @@ impl SpecializedRenderPipeline for BloomDownsamplingPipeline {
blend: None,
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
primitive: PrimitiveState::default(),
depth_stencil: None,
multisample: MultisampleState::default(),
push_constant_ranges: Vec::new(),
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_core_pipeline/src/bloom/upsampling_pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,12 @@ impl SpecializedRenderPipeline for BloomUpsamplingPipeline {
}),
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
primitive: PrimitiveState::default(),
depth_stencil: None,
multisample: MultisampleState::default(),
push_constant_ranges: Vec::new(),
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_core_pipeline/src/deferred/copy_lighting_id.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ impl FromWorld for CopyDeferredLightingIdPipeline {
shader_defs: vec![],
entry_point: "fragment".into(),
targets: vec![],
compilation_options: Default::default(),
}),
primitive: PrimitiveState::default(),
depth_stencil: Some(DepthStencilState {
Expand All @@ -156,7 +157,6 @@ impl FromWorld for CopyDeferredLightingIdPipeline {
}),
multisample: MultisampleState::default(),
push_constant_ranges: vec![],
zero_initialize_workgroup_memory: false,
});

Self {
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_core_pipeline/src/dof/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -815,8 +815,8 @@ impl SpecializedRenderPipeline for DepthOfFieldPipeline {
DofPass::BokehPass1 => "bokeh_pass_1".into(),
},
targets,
compilation_options: Default::default(),
}),
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_core_pipeline/src/experimental/mip_generation/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -497,7 +497,7 @@ impl SpecializedComputePipeline for DownsampleDepthPipeline {
} else {
"downsample_depth_first".into()
},
zero_initialize_workgroup_memory: false,
compilation_options: Default::default(),
}
}
}
Expand Down
1 change: 1 addition & 0 deletions crates/bevy_core_pipeline/src/fullscreen_vertex_shader/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ impl FullscreenShader {
shader_defs: Vec::new(),
entry_point: "fullscreen_vertex_shader".into(),
buffers: Vec::new(),
compilation_options: Default::default(),
}
}
}
2 changes: 1 addition & 1 deletion crates/bevy_core_pipeline/src/motion_blur/pipeline.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,12 +149,12 @@ impl SpecializedRenderPipeline for MotionBlurPipeline {
blend: None,
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
primitive: PrimitiveState::default(),
depth_stencil: None,
multisample: MultisampleState::default(),
push_constant_ranges: vec![],
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_core_pipeline/src/oit/resolve/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,13 +227,13 @@ fn specialize_oit_resolve_pipeline(
}),
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
vertex: fullscreen_shader.to_vertex_state(),
primitive: PrimitiveState::default(),
depth_stencil: None,
multisample: MultisampleState::default(),
push_constant_ranges: vec![],
zero_initialize_workgroup_memory: false,
}
}

Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_core_pipeline/src/post_process/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,12 +333,12 @@ impl SpecializedRenderPipeline for PostProcessingPipeline {
blend: None,
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
primitive: default(),
depth_stencil: None,
multisample: default(),
push_constant_ranges: vec![],
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down
3 changes: 2 additions & 1 deletion crates/bevy_core_pipeline/src/skybox/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ impl SpecializedRenderPipeline for SkyboxPipeline {
shader_defs: Vec::new(),
entry_point: "skybox_vertex".into(),
buffers: Vec::new(),
compilation_options: Default::default(),
},
primitive: PrimitiveState::default(),
depth_stencil: Some(DepthStencilState {
Expand Down Expand Up @@ -235,8 +236,8 @@ impl SpecializedRenderPipeline for SkyboxPipeline {
blend: None,
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_core_pipeline/src/skybox/prepass.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ impl SpecializedRenderPipeline for SkyboxPrepassPipeline {
shader_defs: vec![],
entry_point: "fragment".into(),
targets: prepass_target_descriptors(key.normal_prepass, true, false),
compilation_options: Default::default(),
}),
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion crates/bevy_core_pipeline/src/tonemapping/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,12 +285,12 @@ impl SpecializedRenderPipeline for TonemappingPipeline {
blend: None,
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
primitive: PrimitiveState::default(),
depth_stencil: None,
multisample: MultisampleState::default(),
push_constant_ranges: Vec::new(),
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down
6 changes: 4 additions & 2 deletions crates/bevy_gizmos/src/pipeline_2d.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ impl SpecializedRenderPipeline for LineGizmoPipeline {
entry_point: "vertex".into(),
shader_defs: shader_defs.clone(),
buffers: line_gizmo_vertex_buffer_layouts(key.strip),
compilation_options: Default::default(),
},
fragment: Some(FragmentState {
shader: self.shader.clone(),
Expand All @@ -141,6 +142,7 @@ impl SpecializedRenderPipeline for LineGizmoPipeline {
blend: Some(BlendState::ALPHA_BLENDING),
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
layout,
primitive: PrimitiveState::default(),
Expand All @@ -167,7 +169,6 @@ impl SpecializedRenderPipeline for LineGizmoPipeline {
},
label: Some("LineGizmo Pipeline 2D".into()),
push_constant_ranges: vec![],
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down Expand Up @@ -234,6 +235,7 @@ impl SpecializedRenderPipeline for LineJointGizmoPipeline {
entry_point: entry_point.into(),
shader_defs: shader_defs.clone(),
buffers: line_joint_gizmo_vertex_buffer_layouts(),
compilation_options: Default::default(),
},
fragment: Some(FragmentState {
shader: self.shader.clone(),
Expand All @@ -244,6 +246,7 @@ impl SpecializedRenderPipeline for LineJointGizmoPipeline {
blend: Some(BlendState::ALPHA_BLENDING),
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
layout,
primitive: PrimitiveState::default(),
Expand All @@ -270,7 +273,6 @@ impl SpecializedRenderPipeline for LineJointGizmoPipeline {
},
label: Some("LineJointGizmo Pipeline 2D".into()),
push_constant_ranges: vec![],
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down
6 changes: 4 additions & 2 deletions crates/bevy_gizmos/src/pipeline_3d.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ impl SpecializedRenderPipeline for LineGizmoPipeline {
entry_point: "vertex".into(),
shader_defs: shader_defs.clone(),
buffers: line_gizmo_vertex_buffer_layouts(key.strip),
compilation_options: Default::default(),
},
fragment: Some(FragmentState {
shader: self.shader.clone(),
Expand All @@ -148,6 +149,7 @@ impl SpecializedRenderPipeline for LineGizmoPipeline {
blend: Some(BlendState::ALPHA_BLENDING),
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
layout,
primitive: PrimitiveState::default(),
Expand All @@ -165,7 +167,6 @@ impl SpecializedRenderPipeline for LineGizmoPipeline {
},
label: Some("LineGizmo 3d Pipeline".into()),
push_constant_ranges: vec![],
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down Expand Up @@ -239,6 +240,7 @@ impl SpecializedRenderPipeline for LineJointGizmoPipeline {
entry_point: entry_point.into(),
shader_defs: shader_defs.clone(),
buffers: line_joint_gizmo_vertex_buffer_layouts(),
compilation_options: Default::default(),
},
fragment: Some(FragmentState {
shader: self.shader.clone(),
Expand All @@ -249,6 +251,7 @@ impl SpecializedRenderPipeline for LineJointGizmoPipeline {
blend: Some(BlendState::ALPHA_BLENDING),
write_mask: ColorWrites::ALL,
})],
compilation_options: Default::default(),
}),
layout,
primitive: PrimitiveState::default(),
Expand All @@ -266,7 +269,6 @@ impl SpecializedRenderPipeline for LineJointGizmoPipeline {
},
label: Some("LineJointGizmo 3d Pipeline".into()),
push_constant_ranges: vec![],
zero_initialize_workgroup_memory: false,
}
}
}
Expand Down
Loading
Loading