Skip to content

Enable state scoped entities by default #19354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 26, 2025
Merged

Enable state scoped entities by default #19354

merged 4 commits into from
May 26, 2025

Conversation

mockersf
Copy link
Member

Objective

  • Enable state scoped entities by default
  • Provide a way to disable it when needed

@mockersf mockersf added the A-States App-level states machines label May 24, 2025
benfrankel
benfrankel approved these changes May 25, 2025
View reviewed changes
Copy link
Contributor

@benfrankel benfrankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@janhohenheim janhohenheim added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it D-Straightforward Simple bug fixes and API improvements, docs, test and examples labels May 25, 2025
@janhohenheim
Copy link
Member

Note: Improves usability of #19296

bushrat011899
bushrat011899 approved these changes May 25, 2025
View reviewed changes
Copy link
Contributor

@bushrat011899 bushrat011899 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense. Just an ergonomics question that might be better suited to a follow-up.

@janhohenheim janhohenheim added this to the 0.17 milestone May 25, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 26, 2025
Merged via the queue into bevyengine:main with commit 8a223be May 26, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bushrat011899 bushrat011899 bushrat011899 approved these changes

@kristoff3r kristoff3r kristoff3r approved these changes

@janhohenheim janhohenheim janhohenheim approved these changes

@benfrankel benfrankel benfrankel approved these changes

Assignees
No one assigned
Labels
A-States App-level states machines D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.17
Development

Successfully merging this pull request may close these issues.
6 participants
@mockersf @janhohenheim @kristoff3r @bushrat011899 @benfrankel @alice-i-cecile