Skip to content

Fix custom relations panics with parent/child relations #19341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix custom relations panics with parent/child relations #19341

wants to merge 1 commit into from

Conversation

HeartofPhos
Copy link

Objective

Fixes #18905

Solution

world.commands().entity(target_entity).queue(command) calls commands.with_entity without an error handler, instead queue on Commands with an error handler

Testing

Added unit test

add custom relations + parent/child test
f552f6d 
add ignore error handler for removing RelationshipTarget
@github-actions GitHub Actions
Copy link
Contributor

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UkoeHB UkoeHB UkoeHB approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Having a custom relation and a parent/child relation at the same time causes panics on despawn
2 participants
@HeartofPhos @UkoeHB