doc(render): fix incorrectly transposed view matrix docs #19317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atlv24
added
C-Docs
atlv24
added
D-Straightforward
tychedelia
approved these changes
May 21, 2025
crates/bevy_render/src/view/mod.rs
Outdated
| /// ⎣ cw / w ch / h near / d 1 ⎦ | ||
| /// ⎡ 2 / w 0 0 cw / w ⎤ | ||
| /// ⎢ 0 2 / h 0 ch / h ⎥ | ||
| /// ⎢ 0 0 1 / d near / d ⎥ |
There was a problem hiding this comment.
I don't know this codebase, but a quick check: is this row correct given the swapping of near and far here https://github.com/bevyengine/bevy/blob/main/crates/bevy_render/src/camera/projection.rs#L561-L562 ?
theotherphil
approved these changes
May 27, 2025
alice-i-cecile
added
S-Ready-For-Final-Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing