-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
refactor(render): move WgpuWrapper into bevy_utils #19303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes for no_std
compatibility (in case someone activates the atomics
feature on wasm32v1-none
for example). Otherwise, I think this is a good idea.
Just need to update line 24 of - std = ["alloc", "bevy_platform/std", "dep:thread_local"]
+ std = ["alloc", "bevy_platform/std", "dep:thread_local", "dep:send_wrapper"] |
It looks like your PR is a breaking change, but you didn't provide a migration guide. Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes. |
I don't believe this needs a migration guide, WgpuWrapper wasn't exposed before. |
My mistake! I saw that it was |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
@atlv24 merge conflicts, sorry! |
Objective
Solution
Testing